1 |
Dnia 2015-08-10, o godz. 11:45:33 |
2 |
Chí-Thanh Christopher Nguyễn <chithanh@g.o> napisał(a): |
3 |
|
4 |
> Ulrich Mueller schrieb: |
5 |
> >> This is not a matter of going l33t, this is a matter of getting rid of |
6 |
> >> redundant and pretty much useless data all the same through almost all |
7 |
> >> commit messages. |
8 |
> > |
9 |
> > +1 |
10 |
> > |
11 |
> > "Gentoo-Bug: 123456" or even "Bug: 123456" is enough to uniquely |
12 |
> > identify a bug. Also it is easier to read (and to type) than its URL |
13 |
> > equivalent. |
14 |
> |
15 |
> I'd like to make the case for a URL in commit messages, like for example |
16 |
> freedesktop.org does, and also the kernel for external reports. |
17 |
> |
18 |
> This allows us to treat Gentoo Bugzilla and upstream/external bug trackers |
19 |
> the same. |
20 |
> Besides, extracting the bug number from the URL is typically trivial. Going |
21 |
> from bug number to URL is sometimes not. |
22 |
> |
23 |
> Regarding the argument that bug URLs change more often than bug numbers, I |
24 |
> think the number of instances when URL changed but the bug numbering didn't |
25 |
> is very low. OpenOffice did this I think, but I can't think of any other |
26 |
> project right now. |
27 |
> |
28 |
> Here are examples from freedesktop and kernel: |
29 |
> http://cgit.freedesktop.org/xorg/xserver/commit/?id=db5337afb248edf81087cf8d74006fc496d70589 |
30 |
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ac88cd738425e04dbed3706621cf613a00708834 |
31 |
> |
32 |
> I prefer the |
33 |
> |
34 |
> Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=333531 |
35 |
> |
36 |
> format even though not all bug trackers are running Bugzilla. "Bug: " works |
37 |
> fine with me too, and we could make |
38 |
> "https://bugs.gentoo.org/show_bug.cgi?id=" optional for Gentoo bugs, to |
39 |
> accommodate for those who insist on not typing so much. |
40 |
|
41 |
Thanks, this is exactly what I wanted. |
42 |
|
43 |
"Fixes", "References", "Bug" are all good. "Bugzilla" goes against your |
44 |
proposal diverging keyword depending on bug tracker software. |
45 |
|
46 |
-- |
47 |
Best regards, |
48 |
Michał Górny |
49 |
<http://dev.gentoo.org/~mgorny/> |