| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA512 |
| 3 |
|
| 4 |
On 29/11/15 10:57, Michał Górny wrote: |
| 5 |
> On Sat, 28 Nov 2015 17:21:00 +0100 Justin Lecher <jlec@g.o> |
| 6 |
> wrote: |
| 7 |
> |
| 8 |
>> Signed-off-by: Justin Lecher <jlec@g.o> --- |
| 9 |
>> eclass/virtualx.eclass | 5 +++++ 1 file changed, 5 insertions(+) |
| 10 |
>> |
| 11 |
>> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass |
| 12 |
>> index 230897b..a5e5457 100644 --- a/eclass/virtualx.eclass +++ |
| 13 |
>> b/eclass/virtualx.eclass @@ -59,6 +59,8 @@ case |
| 14 |
>> ${VIRTUALX_REQUIRED} in RDEPEND="" ;; optional|tests) + [[ |
| 15 |
>> ${EAPI} == [2345] ]] \ + || die 'Values "optional" and "tests" |
| 16 |
>> are unsupported for VIRTUALX_REQUIRED' |
| 17 |
> |
| 18 |
> You don't mention EAPI here, which can get confusing. |
| 19 |
|
| 20 |
Valid point. |
| 21 |
|
| 22 |
> |
| 23 |
>> # deprecated section YAY. eqawarn "VIRTUALX_REQUIRED=optional and |
| 24 |
>> VIRTUALX_REQUIRED=tests are deprecated." eqawarn "You can drop |
| 25 |
>> the variable definition completely from ebuild," @@ -177,6 +179,9 |
| 26 |
>> @@ virtualmake() { Xmake() { debug-print-function ${FUNCNAME} |
| 27 |
>> "$@" |
| 28 |
>> |
| 29 |
>> + [[ ${EAPI} == [2345] ]] \ + || die "${FUNCNAME} is removed in |
| 30 |
>> EAPI > 5; use Xemake -j1 instead" + eqawarn "you should not |
| 31 |
>> execute make directly" eqawarn "rather execute Xemake -j1 if you |
| 32 |
>> have issues with parallel make" VIRTUALX_COMMAND="emake -j1" |
| 33 |
>> virtualmake "$@" |
| 34 |
> |
| 35 |
> Still, if you introduced virtx earlier, you wouldn't have to |
| 36 |
> change this die message later on ;-). |
| 37 |
> |
| 38 |
|
| 39 |
Principally you are right, but resorting the patches generates lots of |
| 40 |
merge conflicts. But let me practice my git skills |
| 41 |
|
| 42 |
-----BEGIN PGP SIGNATURE----- |
| 43 |
Version: GnuPG/MacGPG2 v2.0 |
| 44 |
|
| 45 |
iQJ8BAEBCgBmBQJWWulWXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w |
| 46 |
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF |
| 47 |
OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiDUwP/09Q4xMEfaPeAlBIrv120PDc |
| 48 |
uqkJeBGHuKDtR6gmgydg+5bVdj6UwElZUsOaNMuBMkCAcrnHfP2WQ/lJafooK4K+ |
| 49 |
baiVqyFXTKemR8ob2hNLLD5lrvWijvjzc9TAutpfVvJm/NnGNRF2BpmnNKMtVWBO |
| 50 |
0RP1pl+Wfjbzzb52KT96GUeeJqunY0EReuoZ2U9pG1HAnVbOGNacxkeSeJA+pfQ4 |
| 51 |
FQPqhnDAOQMS0p/uXro8h8TeDRIF2wwcRvmCOePKjRF/Ut6sw1/Pogj6iuTxTyaz |
| 52 |
m16ebTJmJ1GKc5mk6Fy4yDp6OR8tdgVwYsq+tjq9fMARqDOA/eJRS0I6/uIgaj0h |
| 53 |
0dHzBYXxtTBixseVvPXAHY80RWSf5nseTceYVPSuHp+PRAhkrVneWsWfnBelqyzS |
| 54 |
Xj+jAPxDRU4gPat3SFt1fRER6A9Ij5VzRTHEEca/kjFvzwxmRs+MxDd7AN8IJK/v |
| 55 |
IhfDCgWf6kth0iCKHUkPZgd/ZOoHOUW4rMsGylObWQpCKz9Uzlo/T44Mj5Lr38nK |
| 56 |
Ydr1AND394O+74EOSGl2IcQiEFUQcrRIkUyOHIqBex/GAaL1wbyfcQ2u7mtNmddm |
| 57 |
Jc5jIM/FzmcDAnZgkxii69fjGb46HsPBUtriAmPydh7mN/ahHy0sPbQqxT3ANYxU |
| 58 |
QTYUPft2ma0fmb9TJjO4 |
| 59 |
=ZaQj |
| 60 |
-----END PGP SIGNATURE----- |
Archives