1 |
On Sat, 28 Nov 2015 17:21:00 +0100 |
2 |
Justin Lecher <jlec@g.o> wrote: |
3 |
|
4 |
> Signed-off-by: Justin Lecher <jlec@g.o> |
5 |
> --- |
6 |
> eclass/virtualx.eclass | 5 +++++ |
7 |
> 1 file changed, 5 insertions(+) |
8 |
> |
9 |
> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass |
10 |
> index 230897b..a5e5457 100644 |
11 |
> --- a/eclass/virtualx.eclass |
12 |
> +++ b/eclass/virtualx.eclass |
13 |
> @@ -59,6 +59,8 @@ case ${VIRTUALX_REQUIRED} in |
14 |
> RDEPEND="" |
15 |
> ;; |
16 |
> optional|tests) |
17 |
> + [[ ${EAPI} == [2345] ]] \ |
18 |
> + || die 'Values "optional" and "tests" are unsupported for VIRTUALX_REQUIRED' |
19 |
|
20 |
You don't mention EAPI here, which can get confusing. |
21 |
|
22 |
> # deprecated section YAY. |
23 |
> eqawarn "VIRTUALX_REQUIRED=optional and VIRTUALX_REQUIRED=tests are deprecated." |
24 |
> eqawarn "You can drop the variable definition completely from ebuild," |
25 |
> @@ -177,6 +179,9 @@ virtualmake() { |
26 |
> Xmake() { |
27 |
> debug-print-function ${FUNCNAME} "$@" |
28 |
> |
29 |
> + [[ ${EAPI} == [2345] ]] \ |
30 |
> + || die "${FUNCNAME} is removed in EAPI > 5; use Xemake -j1 instead" |
31 |
> + |
32 |
> eqawarn "you should not execute make directly" |
33 |
> eqawarn "rather execute Xemake -j1 if you have issues with parallel make" |
34 |
> VIRTUALX_COMMAND="emake -j1" virtualmake "$@" |
35 |
|
36 |
Still, if you introduced virtx earlier, you wouldn't have to change |
37 |
this die message later on ;-). |
38 |
|
39 |
-- |
40 |
Best regards, |
41 |
Michał Górny |
42 |
<http://dev.gentoo.org/~mgorny/> |