Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | Sergei Trofimovich <slyfox@g.o> | ||
| Cc: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH 1/5] haskell-cabal.eclass: drop EAPI={0..5} support | ||
| Date: | Tue, 06 Jul 2021 07:34:28 | ||
| Message-Id: | u8s2jzyix@gentoo.org | ||
| In Reply to: | [gentoo-dev] [PATCH 1/5] haskell-cabal.eclass: drop EAPI={0..5} support by Sergei Trofimovich |
||
| 1 | >>>>> On Tue, 06 Jul 2021, Sergei Trofimovich wrote: |
| 2 | |
| 3 | > case "${EAPI:-0}" in |
| 4 | |
| 5 | This could be just ${EAPI} now (and quotes were never necessary). |
| 6 | |
| 7 | > - 0|1) ;; |
| 8 | > - 2|3|4|5|6|7) HASKELL_CABAL_EXPF+=" src_configure" ;; |
| 9 | > + 6|7) ;; |
| 10 | > *) die "EAPI ${EAPI} unsupported." ;; |
| 11 | |
| 12 | |
| 13 | I'd suggest to update to die message to what is used in other eclasses |
| 14 | (see toolchain-funcs.eclass for example): |
| 15 | |
| 16 | *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; |
| 17 | |
| 18 | > esac |
| 19 | |
| 20 | Same comment for the other eclasses of this series. |
| 21 | |
| 22 | Ulrich |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH 1/5] haskell-cabal.eclass: drop EAPI={0..5} support | Sergei Trofimovich <slyfox@g.o> |