| 1 |
On Tue, 06 Jul 2021 09:34:14 +0200 |
| 2 |
Ulrich Mueller <ulm@g.o> wrote: |
| 3 |
|
| 4 |
> >>>>> On Tue, 06 Jul 2021, Sergei Trofimovich wrote: |
| 5 |
> |
| 6 |
> > case "${EAPI:-0}" in |
| 7 |
> |
| 8 |
> This could be just ${EAPI} now (and quotes were never necessary). |
| 9 |
> |
| 10 |
> > - 0|1) ;; |
| 11 |
> > - 2|3|4|5|6|7) HASKELL_CABAL_EXPF+=" src_configure" ;; |
| 12 |
> > + 6|7) ;; |
| 13 |
> > *) die "EAPI ${EAPI} unsupported." ;; |
| 14 |
> |
| 15 |
> |
| 16 |
> I'd suggest to update to die message to what is used in other eclasses |
| 17 |
> (see toolchain-funcs.eclass for example): |
| 18 |
> |
| 19 |
> *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; |
| 20 |
> |
| 21 |
> > esac |
| 22 |
> |
| 23 |
> Same comment for the other eclasses of this series. |
| 24 |
> |
| 25 |
> Ulrich |
| 26 |
|
| 27 |
Sounds good. Done both as: |
| 28 |
|
| 29 |
--- a/eclass/haskell-cabal.eclass |
| 30 |
+++ b/eclass/haskell-cabal.eclass |
| 31 |
@@ -40,11 +40,11 @@ |
| 32 |
# FEATURE can be removed once https://github.com/haskell/cabal/issues/7213 |
| 33 |
# is fixed. |
| 34 |
|
| 35 |
-case "${EAPI:-0}" in |
| 36 |
+case ${EAPI} in |
| 37 |
# eutils is for eqawarn |
| 38 |
6|7) inherit eutils ;; |
| 39 |
8) ;; |
| 40 |
- *) die "EAPI ${EAPI} unsupported." ;; |
| 41 |
+ *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; |
| 42 |
esac |
| 43 |
|
| 44 |
inherit ghc-package multilib toolchain-funcs |
| 45 |
|
| 46 |
|
| 47 |
-- |
| 48 |
|
| 49 |
Sergei |
Archives