1 |
On 02/06/15 23:52, Mike Frysinger wrote: |
2 |
> On 02 Jun 2015 23:07, Michael Palimaka wrote: |
3 |
>> On 02/06/15 21:38, Mike Frysinger wrote: |
4 |
>>> On 02 Jun 2015 20:47, Michael Palimaka wrote: |
5 |
>>>> On 02/06/15 17:04, Michał Górny wrote: |
6 |
>>>>> Dnia 2015-06-02, o godz. 03:58:35 |
7 |
>>>>> "Michael Sterrett (mr_bones_)" <mr_bones_@g.o> napisał(a): |
8 |
>>>>>> -DEPEND="readline? ( sys-libs/readline ) |
9 |
>>>>>> +DEPEND="readline? ( sys-libs/readline:0 ) |
10 |
>>>>> |
11 |
>>>>> This should be actually := (or :0=) for both deps since gnugo links to |
12 |
>>>>> them. This also applies to your remaining 'warning silencing' commits. |
13 |
>>>> |
14 |
>>>> Why? Blindly adding the subslot dep is a bad idea. |
15 |
>>> |
16 |
>>> in this particular case, the subslot usage is what we want since we're |
17 |
>>> compiling+linking against it. using readline:0 vs readline is still an |
18 |
>>> improvement though. |
19 |
>>> |
20 |
>>> we also want a subslot on ncurses since we compile+link against it. |
21 |
>>> |
22 |
>>> i think it's pretty uncommon to use readline in a package and not want a |
23 |
>>> subslot. your package would have to be doing something uncommon like |
24 |
>>> dlopening it since the only thing readline provides is a library ... |
25 |
>> |
26 |
>> Neither readline nor ncurses define an explicit subslot, so I don't know |
27 |
>> what their future meaning might be. |
28 |
> |
29 |
> their meaning would be the reasonable one -- to track the SONAME. while it |
30 |
> hasn't been deployed yet (due to those packages being on EAPI=4), i don't know |
31 |
> what other value you'd expect it to be. they've both broken their SONAMEs in |
32 |
> the past. readline in particular has been every major version (4.x, 5.x, 6.x). |
33 |
> -mike |
34 |
> |
35 |
|
36 |
Since you've clarified the future meaning for ncurses/readline, it's not |
37 |
a problem. |
38 |
|
39 |
The point was it's not a good idea to use the operator unless without |
40 |
knowing what it means for the package in question (since a subslot can |
41 |
be used to handle a number of different situations, as I wrote previously). |