| 1 |
On 02 Jun 2015 23:07, Michael Palimaka wrote: |
| 2 |
> On 02/06/15 21:38, Mike Frysinger wrote: |
| 3 |
> > On 02 Jun 2015 20:47, Michael Palimaka wrote: |
| 4 |
> >> On 02/06/15 17:04, Michał Górny wrote: |
| 5 |
> >>> Dnia 2015-06-02, o godz. 03:58:35 |
| 6 |
> >>> "Michael Sterrett (mr_bones_)" <mr_bones_@g.o> napisał(a): |
| 7 |
> >>>> -DEPEND="readline? ( sys-libs/readline ) |
| 8 |
> >>>> +DEPEND="readline? ( sys-libs/readline:0 ) |
| 9 |
> >>> |
| 10 |
> >>> This should be actually := (or :0=) for both deps since gnugo links to |
| 11 |
> >>> them. This also applies to your remaining 'warning silencing' commits. |
| 12 |
> >> |
| 13 |
> >> Why? Blindly adding the subslot dep is a bad idea. |
| 14 |
> > |
| 15 |
> > in this particular case, the subslot usage is what we want since we're |
| 16 |
> > compiling+linking against it. using readline:0 vs readline is still an |
| 17 |
> > improvement though. |
| 18 |
> > |
| 19 |
> > we also want a subslot on ncurses since we compile+link against it. |
| 20 |
> > |
| 21 |
> > i think it's pretty uncommon to use readline in a package and not want a |
| 22 |
> > subslot. your package would have to be doing something uncommon like |
| 23 |
> > dlopening it since the only thing readline provides is a library ... |
| 24 |
> |
| 25 |
> Neither readline nor ncurses define an explicit subslot, so I don't know |
| 26 |
> what their future meaning might be. |
| 27 |
|
| 28 |
their meaning would be the reasonable one -- to track the SONAME. while it |
| 29 |
hasn't been deployed yet (due to those packages being on EAPI=4), i don't know |
| 30 |
what other value you'd expect it to be. they've both broken their SONAMEs in |
| 31 |
the past. readline in particular has been every major version (4.x, 5.x, 6.x). |
| 32 |
-mike |
Archives