Gentoo Archives: gentoo-dev

From: "Anthony G. Basile" <blueness@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [RFC] Update toolchain.eclass to deal with .xz compressed tarball for gcc-6.4.0
Date: Wed, 02 Aug 2017 21:09:52
Message-Id: 2777c976-b0b9-ee7c-deb1-fac9282bf679@gentoo.org
In Reply to: Re: [gentoo-dev] [RFC] Update toolchain.eclass to deal with .xz compressed tarball for gcc-6.4.0 by Mike Gilbert
1 On 8/2/17 5:00 PM, Mike Gilbert wrote:
2 > On Wed, Aug 2, 2017 at 4:52 PM, Anthony G. Basile <blueness@g.o> wrote:
3 >> Hi everyone,
4 >>
5 >> Upstream gnu.org used to provide .gz and .bz2 compressed tarballs for
6 >> gcc's source code. With gcc-6.4.0 however, they only provide .gz and
7 >> .xz. Our toolchain.eclass is written only for .bz2. I'd like to commit
8 >> the attached patch to deal with this change. A better fix would
9 >> autodetect whether upstream has .bz2 or .xz but I'm not sure how to
10 >> proceed with that.
11 >
12 > Another option would be to move the SRC_URI setting code into the
13 > individual ebuilds, instead of setting it in the eclass.
14 >
15
16 I would still have problems with the unpack which I can't override.
17
18
19
20 Also, [Arfrever] on IRC suggested that instead of
21
22 if tc_version_is_between 6.4.0 7 ; then
23
24 I use
25
26 if tc_version_is_between 5.5 6 || tc_version_is_between 6.4 7 ||
27 tc_version_is_at_least 7.2 ; then
28
29 to better future proof the code. The assumption here being that gnu.org
30 will continue using .xz instead of .bz2 going forward which seems
31 reasonable.
32
33 --
34 Anthony G. Basile, Ph.D.
35 Gentoo Linux Developer [Hardened]
36 E-Mail : blueness@g.o
37 GnuPG FP : 1FED FAD9 D82C 52A5 3BAB DC79 9384 FA6E F52D 4BBA
38 GnuPG ID : F52D4BBA