Gentoo Archives: gentoo-dev

From: Patrick Lauer <patrick@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Uncoordinated changes
Date: Thu, 11 Feb 2016 20:16:34
Message-Id: 56BCEBE6.8090404@gentoo.org
1 ... or why just changing stuff is not enough:
2
3 A few days ago I was told that
4 http://euscan.gentooexperimental.org/herds/ was displaying an empty
5 list. Which is annoying because people sometimes want to see what
6 upstream updates are available for their herd.
7
8 Well, we renamed herd to project. Because reasons.
9
10 I don't care how it is named, but this change broke euscan in a
11 user-visible way. Now I could just try to rename things there too, but
12 that won't work:
13
14 euscan uses gentoolkit for parsing metadata.xml and herds.xml
15 (Since herds.xml is basically unmaintained cruft at this point this will
16 break soon anyway ... but ...)
17 Changing gentoolkit to use projects.xml instead of herds.xml won't be a
18 simple migration since the data organization changed.
19
20 Now instead of looking up [metadata.xml] -> (herd name) -> [herds.xml]
21 -> email it goes backwards:
22 [metadata.xml] -> (maintainer type=project) -> email -> [projects.xml]
23 -> Project name
24
25 Since this involves XML and python's ElementTree library it's a
26 nontrivial change that also removes a few now useless helpers
27 (_get_herd_email has no reason to be, but we'd need a _get_herd_name
28 helper instead. Err, get_proj ... ah well, whatever name works)
29
30 And all that just so (1) gentoolkit output works and (2) euscan updates
31 properly. Both of which I don't really care about much, but now that
32 I've invested ~4h into debugging and trying to fix it I'm a tiny bit
33 IRRITATED.
34
35
36
37 Please, next time someone has the brilliant idea of changing stuff just
38 to change it (I still don't see a reason why we had to change
39 metadata.xml?), it should be required that support tools are fixed
40 *before* the change, and working versions released. This avoids grumpy
41 people and makes it harder for those that change things to head-in-sand
42 and claim everything works as expected when it obviously doesn't.
43
44
45 And this, again, supports my default phrase: "Change is not Progress",
46 because now we have regressions and user-visible breakage, and it's hard
47 to qualify how the change actually improved anything because we haven't
48 actually *finished* the change. (Like the git migration that is still
49 ongoing ...)
50
51 Do the needfull! Be of excellent moral person!

Replies

Subject Author
Re: [gentoo-dev] Uncoordinated changes Rich Freeman <rich0@g.o>
Re: [gentoo-dev] Uncoordinated changes "Michał Górny" <mgorny@g.o>
Re: [gentoo-dev] Uncoordinated changes Patrick Lauer <patrick@g.o>