1 |
On 9/9/19 2:19 PM, Zac Medico wrote: |
2 |
> On 9/9/19 10:34 AM, William Hubbs wrote: |
3 |
> |
4 |
>> There is another option I want to try which is adding "go mod vendor" to |
5 |
>> src_unpack for go packages. |
6 |
> |
7 |
> If you do that then it will violate FEATURES=network-sandbox (default) |
8 |
> unless you also do PROPERTIES+=" live". |
9 |
> |
10 |
> We could add a separate PROPERTIES value for this, I've suggested it |
11 |
> before but both Michał Górny and Ulrich Mueller were against it: |
12 |
> |
13 |
|
14 |
This is the precisely what FEATURES=network-sandbox exists to prevent. |
15 |
|
16 |
Bundling dependencies, hitting the network, shelling out to a |
17 |
language-specific package manager, depending on specific upstream |
18 |
commits, and sidestepping existing QA mechanisms to make this all |
19 |
possible... it's bad idea bingo. |