| 1 |
On 26/01/16 15:10, Davide Pesavento wrote: |
| 2 |
> On Tue, Jan 26, 2016 at 1:50 PM, Michał Górny <mgorny@g.o> wrote: |
| 3 |
>> Dnia 26 stycznia 2016 13:36:00 CET, Davide Pesavento <pesa@g.o> napisał(a): |
| 4 |
>>> On Mon, Jan 25, 2016 at 9:29 PM, Justin Lecher <jlec@g.o> wrote: |
| 5 |
>>>> Signed-off-by: Justin Lecher <jlec@g.o> |
| 6 |
>>>> --- |
| 7 |
>>>> eclass/cmake-utils.eclass | 2 +- |
| 8 |
>>>> 1 file changed, 1 insertion(+), 1 deletion(-) |
| 9 |
>>>> |
| 10 |
>>>> diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass |
| 11 |
>>>> index 01de9a5..23339ab 100644 |
| 12 |
>>>> --- a/eclass/cmake-utils.eclass |
| 13 |
>>>> +++ b/eclass/cmake-utils.eclass |
| 14 |
>>>> @@ -112,7 +112,7 @@ _CMAKE_UTILS_ECLASS=1 |
| 15 |
>>>> # for econf and is needed to pass TRY_RUN results when |
| 16 |
>>> cross-compiling. |
| 17 |
>>>> # Should be set by user in a per-package basis in |
| 18 |
>>> /etc/portage/package.env. |
| 19 |
>>>> |
| 20 |
>>>> -case ${EAPI} in |
| 21 |
>>>> +case ${EAPI:-0} in |
| 22 |
>>>> 2|3|4|5|6) : ;; |
| 23 |
>>>> *) die "EAPI=${EAPI:-0} is not supported" ;; |
| 24 |
>>>> esac |
| 25 |
>>>> -- |
| 26 |
>>>> 2.7.0 |
| 27 |
>>>> |
| 28 |
>>> |
| 29 |
>>> Why? |
| 30 |
>> |
| 31 |
>> Indeed, why? I think it would be cleaner to simply quote the parameter to case. |
| 32 |
>> |
| 33 |
> |
| 34 |
> AFAIK even quoting would be unnecessary in this context (assuming bash). |
| 35 |
> |
| 36 |
|
| 37 |
Guys, if you are sure, that it is enough, then I will drop it. I just |
| 38 |
thought there has to be something. But I tested it and it's unnecessary. |
| 39 |
At least with latest bash. |
| 40 |
|
| 41 |
Justin |
Archives