Gentoo Archives: gentoo-dev

From: Davide Pesavento <pesa@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o, kde@g.o, Justin Lecher <jlec@g.o>
Subject: Re: [gentoo-dev] [PATCH 3/3] cmake-utils.eclass: Define default EAPI to 0
Date: Tue, 26 Jan 2016 14:11:02
Message-Id: CADfzvvbA0BhM58B5dp1Ji=qjt4nOetLtGPuirLV-Lfnd=BKEOA@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH 3/3] cmake-utils.eclass: Define default EAPI to 0 by "Michał Górny"
1 On Tue, Jan 26, 2016 at 1:50 PM, Michał Górny <mgorny@g.o> wrote:
2 > Dnia 26 stycznia 2016 13:36:00 CET, Davide Pesavento <pesa@g.o> napisał(a):
3 >>On Mon, Jan 25, 2016 at 9:29 PM, Justin Lecher <jlec@g.o> wrote:
4 >>> Signed-off-by: Justin Lecher <jlec@g.o>
5 >>> ---
6 >>> eclass/cmake-utils.eclass | 2 +-
7 >>> 1 file changed, 1 insertion(+), 1 deletion(-)
8 >>>
9 >>> diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
10 >>> index 01de9a5..23339ab 100644
11 >>> --- a/eclass/cmake-utils.eclass
12 >>> +++ b/eclass/cmake-utils.eclass
13 >>> @@ -112,7 +112,7 @@ _CMAKE_UTILS_ECLASS=1
14 >>> # for econf and is needed to pass TRY_RUN results when
15 >>cross-compiling.
16 >>> # Should be set by user in a per-package basis in
17 >>/etc/portage/package.env.
18 >>>
19 >>> -case ${EAPI} in
20 >>> +case ${EAPI:-0} in
21 >>> 2|3|4|5|6) : ;;
22 >>> *) die "EAPI=${EAPI:-0} is not supported" ;;
23 >>> esac
24 >>> --
25 >>> 2.7.0
26 >>>
27 >>
28 >>Why?
29 >
30 > Indeed, why? I think it would be cleaner to simply quote the parameter to case.
31 >
32
33 AFAIK even quoting would be unnecessary in this context (assuming bash).

Replies

Subject Author
Re: [gentoo-dev] [PATCH 3/3] cmake-utils.eclass: Define default EAPI to 0 "Justin Lecher (jlec)" <jlec@g.o>