Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o, Davide Pesavento <pesa@g.o>
Cc: kde@g.o, Justin Lecher <jlec@g.o>
Subject: Re: [gentoo-dev] [PATCH 3/3] cmake-utils.eclass: Define default EAPI to 0
Date: Tue, 26 Jan 2016 12:51:15
Message-Id: 1AB8AB1D-D6D4-459A-BE3D-CA7FA0524031@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 3/3] cmake-utils.eclass: Define default EAPI to 0 by Davide Pesavento
1 Dnia 26 stycznia 2016 13:36:00 CET, Davide Pesavento <pesa@g.o> napisał(a):
2 >On Mon, Jan 25, 2016 at 9:29 PM, Justin Lecher <jlec@g.o> wrote:
3 >> Signed-off-by: Justin Lecher <jlec@g.o>
4 >> ---
5 >> eclass/cmake-utils.eclass | 2 +-
6 >> 1 file changed, 1 insertion(+), 1 deletion(-)
7 >>
8 >> diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
9 >> index 01de9a5..23339ab 100644
10 >> --- a/eclass/cmake-utils.eclass
11 >> +++ b/eclass/cmake-utils.eclass
12 >> @@ -112,7 +112,7 @@ _CMAKE_UTILS_ECLASS=1
13 >> # for econf and is needed to pass TRY_RUN results when
14 >cross-compiling.
15 >> # Should be set by user in a per-package basis in
16 >/etc/portage/package.env.
17 >>
18 >> -case ${EAPI} in
19 >> +case ${EAPI:-0} in
20 >> 2|3|4|5|6) : ;;
21 >> *) die "EAPI=${EAPI:-0} is not supported" ;;
22 >> esac
23 >> --
24 >> 2.7.0
25 >>
26 >
27 >Why?
28
29 Indeed, why? I think it would be cleaner to simply quote the parameter to case.
30
31
32 --
33 Best regards,
34 Michał Górny (by phone)

Replies