1 |
On Fri, 2019-09-20 at 13:24 -0400, Mike Gilbert wrote: |
2 |
> On Fri, Sep 20, 2019 at 12:55 PM Michał Górny <mgorny@g.o> wrote: |
3 |
> > On Fri, 2019-09-20 at 12:41 -0400, Mike Gilbert wrote: |
4 |
> > > On Fri, Sep 20, 2019 at 12:11 PM Michał Górny <mgorny@g.o> wrote: |
5 |
> > > > On Fri, 2019-09-20 at 11:46 -0400, Mike Gilbert wrote: |
6 |
> > > > > Recently, a large number of bugs were filed against packages that have |
7 |
> > > > > USE flag names which contain underscores. Apparently PMS prohibits |
8 |
> > > > > this except when the USE flag is part of a USE_EXPAND variable. |
9 |
> > > > > |
10 |
> > > > > https://projects.gentoo.org/pms/7/pms.html#x1-200003.1.4 |
11 |
> > > > > |
12 |
> > > > > I'm not certain when this text was added to PMS, or how many of the |
13 |
> > > > > affected USE flags pre-date this policy. |
14 |
> > > > > |
15 |
> > > > > Portage seems to have no issue dealing with underscores, so this |
16 |
> > > > > doesn't seem to be solving any technical problem. |
17 |
> > > > > |
18 |
> > > > > I am pretty sure that renaming a bunch of USE flags will cause some |
19 |
> > > > > amount of end-user confusion, for very little benefit. Is enforcing |
20 |
> > > > > this part of PMS really worth it? |
21 |
> > > > |
22 |
> > > > And having packages with pretended-USE_EXPAND-that-does-not-work-as- |
23 |
> > > > USE_EXPAND is less confusing to the users? |
24 |
> > > |
25 |
> > > I doubt users immediately think "USE_EXPAND" when they see an underscore. |
26 |
> > > |
27 |
> > > Portage's seems fairly unambiguous to me. For example: |
28 |
> > > |
29 |
> > > % emerge -pv1O app-misc/foo |
30 |
> > > |
31 |
> > > These are the packages that would be merged, in order: |
32 |
> > > |
33 |
> > > [ebuild N ] app-misc/foo-0::local USE="-modern_kernel" |
34 |
> > > PYTHON_TARGETS="python3_7" VIDEO_CARDS="radeon" 0 KiB |
35 |
> > > |
36 |
> > > Total: 1 package (1 new), Size of downloads: 0 KiB |
37 |
> > > |
38 |
> > > I don't think anyone would mistake "modern_kernel" for a USE_EXPAND |
39 |
> > > value given the above. |
40 |
> > > |
41 |
> > |
42 |
> > Look at the humongous list of flags on dev-libs/aws-sdk-cpp. They all |
43 |
> > start with 'aws_targets' which is a clear attempt to emulate USE_EXPAND. |
44 |
> > Expect that they won't work as USE_EXPAND, user typing: |
45 |
> > |
46 |
> > AWS_TARGETS="foo bar baz" |
47 |
> > |
48 |
> > will just wildly confused, and in the end this prefixing is just silly |
49 |
> > and causes the flag names to become awfully long. |
50 |
> |
51 |
> Ok, so you chery-picked one particularly horrible example. The Portage |
52 |
> output still puts them in USE="" section, though the user probably |
53 |
> won't see that given the massive USE flag list. |
54 |
> |
55 |
> My point still stands for many of the other packages in the repo that |
56 |
> don't have several dozen flags. |
57 |
> |
58 |
|
59 |
I'm sorry to say but you can't expect automated software to be able to |
60 |
distinguish a 'not horrible' vs 'horrible' use. The test catches both |
61 |
cases. The latter case deserves fixing, the former usually involves 1-2 |
62 |
flag, so there's no harm in changing it. If for no other reason, then |
63 |
to improve consistency in USE flags and save shift key a bit. |
64 |
|
65 |
The hyphen variant is already in the majority in global flags. What's |
66 |
the harm in having local flags match that? |
67 |
|
68 |
-- |
69 |
Best regards, |
70 |
Michał Górny |