1 |
On Wed, May 04, 2016 at 07:41:39PM +1000, Sam Jorna wrote: |
2 |
> On Wed, May 04, 2016 at 10:57:44AM +0200, Kristian Fiskerstrand wrote: |
3 |
> > On 05/04/2016 10:52 AM, Sam Jorna wrote: |
4 |
> > > On Wed, May 04, 2016 at 10:00:05AM +0200, Ulrich Mueller wrote: |
5 |
> > >>>>>>> On Wed, 4 May 2016, Austin English wrote: |
6 |
> > >> |
7 |
> > >>>> Your list of affected packages obtained with "git grep" in the |
8 |
> > >>>> Portage tree will not be complete, since the command won't catch |
9 |
> > >>>> any init scripts installed from elsewhere. You should look for the |
10 |
> > >>>> set of installed files instead. |
11 |
> > >> |
12 |
> > >>> How is that relevant here at all? I'm cleaning up portage installed |
13 |
> > >>> init scripts, [...] |
14 |
> > >> |
15 |
> > >> You are cleaning up only those init scripts that are installed from |
16 |
> > >> FILESDIR, but you will miss the ones that are installed from a file |
17 |
> > >> in SRC_URI. |
18 |
> > > |
19 |
> > > Perhaps an alternate way to do it would be to have a QA check look at |
20 |
> > > any files installed to ${D}etc/init.d/ and throw a warning if their |
21 |
> > > shebang is "#!/sbin/runscript" |
22 |
> > > |
23 |
> > |
24 |
> > A repoman check is a much saner approach, I'm not convinced there is |
25 |
> > sufficient need for this change to begin with, in particular to start |
26 |
> > touching a wide range of packages. Breaking backwards compatibility in |
27 |
> > any way should have a darn good reason, and I haven't seen one yet |
28 |
> |
29 |
> I'm not arguing for or against it in general, just in terms of technical |
30 |
> implementation. |
31 |
> |
32 |
> That being said, a repoman check would only catch those distributed in |
33 |
> ${FILESDIR} as well. My thinking with the above was to also identify |
34 |
> those installed from distfiles to be handled accordingly. |
35 |
|
36 |
Actually, you won't need to worry about any qa checks in portage, |
37 |
because I am going to put a deprecation warning in OpenRC upstream which |
38 |
will be displayed when a service script invokes runscript instructing |
39 |
you to convert to openrc-run. |
40 |
|
41 |
OpenRC will keep runscript, with this warning, for a while. |
42 |
|
43 |
William |