Re: [gentoo-dev] [PATCH 11/15] perl-module.eclass: Introduce DIST_TEST_OVERRIDE in EAPI=6

[Michał Górny]

Dnia 11 grudnia 2015 22:03:07 CET, dilfridge@g.o napisał(a):
>From: "Andreas K. Huettel (dilfridge)" <dilfridge@g.o>
>
>---
> eclass/perl-module.eclass | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
>index 0d428d2..4dc39eb 100644
>--- a/eclass/perl-module.eclass
>+++ b/eclass/perl-module.eclass
>@@ -328,6 +328,14 @@ perl-module_src_compile() {
> #  DIST_TEST=parallel
> #  DIST_TEST=skip
>
>+# @ECLASS-VARIABLE: DIST_TEST_OVERRIDE
>+# @DESCRIPTION:
>+# (EAPI=6) Variable that controls if tests are run in the test phase
>+# at all, and if yes under which conditions. It is intended for use in
>+# make.conf or the environment by ebuild authors during testing, and
>+# accepts the same values as DIST_TEST. If set, it overrides DIST_TEST
>+# completely. DO NOT USE THIS IN EBUILDS!
>+
> # @FUNCTION: perl-module_src-test
> # @USAGE: perl-module_src_test()
> # @DESCRIPTION:
>@@ -342,7 +350,8 @@ perl-module_src_test() {
> 	if [[ ${EAPI:-0} = 5 ]] ; then
> 		my_test_control=${SRC_TEST}
> 	else
>-		my_test_control=${DIST_TEST:-do parallel}
>+		[[ -n "${DIST_TEST_OVERRIDE}" ]] && ewarn DIST_TEST_OVERRIDE is set
>to ${DIST_TEST_OVERRIDE}
>+		my_test_control=${DIST_TEST_OVERRIDE:-${DIST_TEST:-do parallel}}
> 	fi
>
>	if has 'do' ${my_test_control} || has 'parallel' ${my_test_control} ;
>then

Why that? This seems really redundant to RESTRICT=test.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.