Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o, dilfridge@g.o
Cc: "Andreas K. Huettel (dilfridge)" <dilfridge@g.o>
Subject: Re: [gentoo-dev] [PATCH 11/15] perl-module.eclass: Introduce DIST_TEST_OVERRIDE in EAPI=6
Date: Sat, 12 Dec 2015 12:07:25
Message-Id: B3844044-4B6E-4621-AF15-35AADB2F4325@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 11/15] perl-module.eclass: Introduce DIST_TEST_OVERRIDE in EAPI=6 by "Michał Górny"
1 Dnia 12 grudnia 2015 13:05:12 CET, "Michał Górny" <mgorny@g.o> napisał(a):
2 >
3 >
4 >Dnia 11 grudnia 2015 22:03:07 CET, dilfridge@g.o napisał(a):
5 >>From: "Andreas K. Huettel (dilfridge)" <dilfridge@g.o>
6 >>
7 >>---
8 >> eclass/perl-module.eclass | 11 ++++++++++-
9 >> 1 file changed, 10 insertions(+), 1 deletion(-)
10 >>
11 >>diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
12 >>index 0d428d2..4dc39eb 100644
13 >>--- a/eclass/perl-module.eclass
14 >>+++ b/eclass/perl-module.eclass
15 >>@@ -328,6 +328,14 @@ perl-module_src_compile() {
16 >> # DIST_TEST=parallel
17 >> # DIST_TEST=skip
18 >>
19 >>+# @ECLASS-VARIABLE: DIST_TEST_OVERRIDE
20 >>+# @DESCRIPTION:
21 >>+# (EAPI=6) Variable that controls if tests are run in the test phase
22 >>+# at all, and if yes under which conditions. It is intended for use
23 >in
24 >>+# make.conf or the environment by ebuild authors during testing, and
25 >>+# accepts the same values as DIST_TEST. If set, it overrides
26 >DIST_TEST
27 >>+# completely. DO NOT USE THIS IN EBUILDS!
28 >>+
29 >> # @FUNCTION: perl-module_src-test
30 >> # @USAGE: perl-module_src_test()
31 >> # @DESCRIPTION:
32 >>@@ -342,7 +350,8 @@ perl-module_src_test() {
33 >> if [[ ${EAPI:-0} = 5 ]] ; then
34 >> my_test_control=${SRC_TEST}
35 >> else
36 >>- my_test_control=${DIST_TEST:-do parallel}
37 >>+ [[ -n "${DIST_TEST_OVERRIDE}" ]] && ewarn DIST_TEST_OVERRIDE is set
38 >>to ${DIST_TEST_OVERRIDE}
39 >>+ my_test_control=${DIST_TEST_OVERRIDE:-${DIST_TEST:-do parallel}}
40 >> fi
41 >>
42 >> if has 'do' ${my_test_control} || has 'parallel' ${my_test_control} ;
43 >>then
44 >
45 >Why that? This seems really redundant to RESTRICT=test.
46
47 I meant FEATURES=-test. Sorry for the confusion.
48
49 --
50 Sent from my Android device with K-9 Mail. Please excuse my brevity.

Replies