Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: Sergei Trofimovich <slyfox@g.o>
Subject: Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild
Date: Tue, 29 Jun 2010 06:25:30
In Reply to: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild by Sergei Trofimovich
> if [[ -z "$1" ]]; then
either lose the quotes or lose the double brackets. hint: the former.
> echo "!!! xmms2_flag() called without a parameter." >&2 > echo "!!! xmms2_flag() <USEFLAG> [<xmms2_flagname>]" >&2
use eerror or die
> if use "$1"; then
USE flag cannot contain spaces or anything else that requires quoting
> else > : # nothing is generated > fi
my, we sure do like to be verbose
> --destdir="${D}" \
you need to give the DESTDIR to configure ? no wonder xmms2 sucks
> ${CTARGET:+--with-target-platform=${CTARGET}} \
i highly suspect this isnt what you think it is. if this option is for cross- compiling, then use ${CHOST}.
> optionals+="$(xmms2_flag $option)"
dont need the quoting when doing ...=$(...)
> "${S}"/waf
the default dir for most src_* funcs is $S, so just use ./waf
> use python && python_mod_optimize $(python_get_sitedir)/xmmsclient
shouldnt sitedir be quoted ? -mike


File name MIME type
signature.asc application/pgp-signature


Subject Author
Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2) Sergei Trofimovich <slyfox@g.o>
Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild "Łukasz Michalik" <bronksos@×××××.com>