Gentoo Archives: gentoo-dev

From: "Rick \\\"Zero_Chaos\\\" Farina" <zerochaos@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] bzr.eclass changes, please review
Date: Fri, 14 Sep 2012 16:13:23
Message-Id: 50535763.9050107@gentoo.org
In Reply to: Re: [gentoo-dev] bzr.eclass changes, please review by Ulrich Mueller
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 On 09/14/2012 11:51 AM, Ulrich Mueller wrote:
5 >>>>>> On Fri, 14 Sep 2012, Rick "Zero Chaos" Farina wrote:
6 >
7 >>> addwrite /
8 >> Am I reading this wrong, or is "addwrite /" being more than just a
9 >> little lazy? I know this isn't part of your change set but it has
10 >> always bothered me that it needs to unlocking writing on the whole
11 >> filesystem to save something in distdir.
12 >
13 > EBZR_STORE_DIR may be redefined, so you cannot be sure that it's below
14 > DISTDIR. Also, it's not known how many of its path components already
15 > exist. I'm not sure if it would be worth the effort to compute a more
16 > accurate argument for addwrite. (Almost all live eclasses do that
17 > "addwrite /", by the way.)
18 I didn't mean to pick on bzr.eclass, I think it's always wrong to do
19 this. And you picked out the exact reasoning I did "I'm not sure if it
20 would be worth the effort to compute a more accurate argument for
21 addwrite." I think it is worth the effort to do it right. I mean
22 (purposeful exaggeration here) we could save the addwrite entirely by
23 just "killall sandbox" or we could prevent from reoccurring by
24 restricting the sandbox feature. Any time you do "addwrite /" you
25 completely defeat the entire purpose of sandbox. It's not write (get it?).
26
27 I'm not saying this is an emergency nor should it hold back any changes
28 you need to make to argue with me about it. However, if you were to do
29 it right that would be cool. Otherwise we could all start fixing our
30 sandbox issues by just doing "addwrite /" at the top of all ebuilds.
31
32 Thanks,
33 Zero
34 >
35 >>> mkdir -p "${EBZR_STORE_DIR}" \
36 >>> || die "${EBZR}: can't mkdir ${EBZR_STORE_DIR}"
37 >
38 > Ulrich
39 >
40 >
41
42 -----BEGIN PGP SIGNATURE-----
43 Version: GnuPG v2.0.19 (GNU/Linux)
44 Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
45
46 iQIcBAEBAgAGBQJQU1djAAoJEKXdFCfdEflKlecP/jVjGN76yb/VJ+5/O75lwwhf
47 7p7pppohVw4gfaiiHOz0uamu37RPPqlmc+LV4TgUxQ+n6VMkdrXG7tU0TTewYEEw
48 mTorfsF5i2aFXJXMRIT5Xz+P+iEx9m4bhbKuxjL17DKs4F9jKToao/1ix2lhNKZX
49 ClnAp+qgKNN2fj/1vnBNkGSIfWF9EEkpfCqC0d2kXLADXJCNqaOmUmVI9+5XXAFw
50 7X+DW1JMRgg64yQ78bztHmmKqQ211WK3JqqmZPxb4bms5RQPCILBjc+OQ97KKwBW
51 woXfV+gZInTrfvgADEFCLeDSKuEojqriu7UrXCBkwNkDEzVdsLWXD25lUzo2bmPP
52 nuUOjBsIiFJAt8UdpAn+y7hDVy5BfClE24FxVSk+ydthlkGNW6T0tMEikBhserJ5
53 bi0qF7qOp6Wu+OVS0a+de2ptcy6z/AVm8ziDSY70mX32GqW0APkft+yvzluibpXZ
54 a37c+zYoytWb1GK5ijC8I29xi5GDilouaX+DMVz2woZChEhYuZ8ElKpHzHgI1HZs
55 dZirnsFjZt4jBBk2iB8NUHyccze4XpmSnwd75w0ltNaAs1IhTATxIbbkRokQJ0F7
56 FteSyd/0jzvRGIIgpTpJBtga4UMkRZxpnG/2OIKn0hy+4tvotwUknwzWDGEdCKQq
57 5k4jnZXA364VLoeYOXeK
58 =0AWM
59 -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-dev] bzr.eclass changes, please review Mike Gilbert <floppym@g.o>