| 1 |
On Wed, 2007-04-11 at 20:02 +0700, Nguyễn Thái Ngọc Duy wrote: |
| 2 |
> > I tend to agree that this is a problem, but only insofar as we've become |
| 3 |
> > too territorial. Many times I see bugs filed with seemingly minor |
| 4 |
> > changes being asked for. A good example is bug #173884 which is a |
| 5 |
> > completely valid request. The change is simple, removing |
| 6 |
> > "insinto /etc/env.d ; doins $somefile" and replacing it with "doenvd |
| 7 |
> > $somefile" instead. Now, this is something that *anyone* with commit |
| 8 |
> > access should feel comfortable doing to *anyone's* packages without fear |
| 9 |
> > of being attacked for touching someone else's packages. |
| 10 |
> |
| 11 |
> I wish we could have a list stating which package you have to contact |
| 12 |
> its maintainer first (and the reason why if possible), or add |
| 13 |
> <restricted> tag in metadata.xml to warn people. The rest of the tree |
| 14 |
> will be free land (unless you break the tree of course) |
| 15 |
|
| 16 |
That's really the point here. You should *never* have to contact the |
| 17 |
maintainer first for minor QA issues like changing something as simple |
| 18 |
as "insinto /etc/env.d ; doins $somefile" into "doenvd $somefile" or |
| 19 |
fixing a typo. The maintainer only needs to be contacted on changes |
| 20 |
that modify the end result. If you're completely rearranging the ebuild |
| 21 |
or trying to add a patch, you should definitely contact the maintainer. |
| 22 |
If you're just cleaning up minor QA issues, it isn't necessary. This |
| 23 |
has always been the case, but perhaps it would be better to state it |
| 24 |
more plainly so people understand that they are allowed to touch |
| 25 |
*anything* in the tree. |
| 26 |
|
| 27 |
The main thing to take into consideration is the scope of who is |
| 28 |
affected. Take a package rename as an example. If your package foo is |
| 29 |
being renamed bar, then I would fully expect you to change all instances |
| 30 |
of foo in dependencies in the tree to bar, as it really only "affects" |
| 31 |
you since it was your package that changed. If you're adding a new |
| 32 |
default local USE that only affects your package, there's no need to ask |
| 33 |
anyone. If you're adding a new default USE that's used in a bunch of |
| 34 |
packages, it should be asked here. |
| 35 |
|
| 36 |
-- |
| 37 |
Chris Gianelloni |
| 38 |
Release Engineering Strategic Lead |
| 39 |
Alpha/AMD64/x86 Architecture Teams |
| 40 |
Games Developer/Council Member/Foundation Trustee |
| 41 |
Gentoo Foundation |
Archives