Gentoo Archives: gentoo-dev

From: Hans de Graaff <graaff@g.o>
To: Sergei Trofimovich <slyfox@g.o>, gentoo-dev@l.g.o
Cc: ruby@g.o
Subject: [gentoo-dev] Re: [PATCH 1/2] ruby-ng.eclass: add missing 'estack' inherit to EAPI=6
Date: Sat, 20 Jul 2019 08:38:19
Message-Id: fe17c2485c753a681d892a762da0f55a25c26bb6.camel@gentoo.org
1 On Sat, 2019-07-20 at 09:24 +0100, Sergei Trofimovich wrote:
2 > Noticed when ran egencache:
3 > $ PORTAGE_ELOG_CLASSES="qa" egencache --repo=gentoo --update --
4 > update-use-local-desc --jobs=$(nproc)
5 > * Call stack:
6 > * ruby-ng.eclass, line 142: Called command_not_found_handle
7 > 'eshopts_push' '-o' 'noglob'
8 > * ebuild.sh, line 325: Called __qa_source '/gentoo-
9 > ebuilds/gentoo/eclass/ruby-fakegem.eclass'
10 > * ebuild.sh, line 624: Called source '/gentoo-
11 > ebuilds/gentoo/dev-ruby/moneta/moneta-1.1.0.ebuild'
12 > * ebuild.sh, line 89: Called die
13 >
14 > Signed-off-by: Sergei Trofimovich <slyfox@g.o>
15 > ---
16 > eclass/ruby-ng.eclass | 3 +++
17 > 1 file changed, 3 insertions(+)
18 >
19 > diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
20 > index a6c4c3396b3..0b0ee696d50 100644
21 > --- a/eclass/ruby-ng.eclass
22 > +++ b/eclass/ruby-ng.eclass
23 > @@ -71,6 +71,9 @@ case ${EAPI} in
24 > 2|3|4|5)
25 > inherits="eutils"
26 > ;;
27 > + 6)
28 > + inherits="estack"
29 > + ;;
30 > esac
31 >
32 > inherit ${inherits} multilib toolchain-funcs ruby-utils
33
34 Ack on this change. It seems this got broken when adding EAPI=6 support
35 but this was never noticed because java-utils-2 also inherits eutils
36 (and versionator).
37
38 Can you commit and push these ASAP? It currently breaks QA. I can also
39 commit them if you want.
40
41 Hans

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies