Gentoo Archives: gentoo-dev

From: Sergei Trofimovich <slyfox@g.o>
To: Hans de Graaff <graaff@g.o>
Cc: gentoo-dev@l.g.o, ruby@g.o
Subject: [gentoo-dev] Re: [PATCH 1/2] ruby-ng.eclass: add missing 'estack' inherit to EAPI=6
Date: Sat, 20 Jul 2019 09:22:32
Message-Id: 20190720102223.67befff4@sf
In Reply to: [gentoo-dev] Re: [PATCH 1/2] ruby-ng.eclass: add missing 'estack' inherit to EAPI=6 by Hans de Graaff
1 On Sat, 20 Jul 2019 10:38:09 +0200
2 Hans de Graaff <graaff@g.o> wrote:
3
4 > On Sat, 2019-07-20 at 09:24 +0100, Sergei Trofimovich wrote:
5 > > Noticed when ran egencache:
6 > > $ PORTAGE_ELOG_CLASSES="qa" egencache --repo=gentoo --update --
7 > > update-use-local-desc --jobs=$(nproc)
8 > > * Call stack:
9 > > * ruby-ng.eclass, line 142: Called command_not_found_handle
10 > > 'eshopts_push' '-o' 'noglob'
11 > > * ebuild.sh, line 325: Called __qa_source '/gentoo-
12 > > ebuilds/gentoo/eclass/ruby-fakegem.eclass'
13 > > * ebuild.sh, line 624: Called source '/gentoo-
14 > > ebuilds/gentoo/dev-ruby/moneta/moneta-1.1.0.ebuild'
15 > > * ebuild.sh, line 89: Called die
16 > >
17 > > Signed-off-by: Sergei Trofimovich <slyfox@g.o>
18 > > ---
19 > > eclass/ruby-ng.eclass | 3 +++
20 > > 1 file changed, 3 insertions(+)
21 > >
22 > > diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
23 > > index a6c4c3396b3..0b0ee696d50 100644
24 > > --- a/eclass/ruby-ng.eclass
25 > > +++ b/eclass/ruby-ng.eclass
26 > > @@ -71,6 +71,9 @@ case ${EAPI} in
27 > > 2|3|4|5)
28 > > inherits="eutils"
29 > > ;;
30 > > + 6)
31 > > + inherits="estack"
32 > > + ;;
33 > > esac
34 > >
35 > > inherit ${inherits} multilib toolchain-funcs ruby-utils
36 >
37 > Ack on this change. It seems this got broken when adding EAPI=6 support
38 > but this was never noticed because java-utils-2 also inherits eutils
39 > (and versionator).
40 >
41 > Can you commit and push these ASAP? It currently breaks QA. I can also
42 > commit them if you want.
43
44 Pushed just now.
45
46 --
47
48 Sergei