| 1 |
[2021-03-17 11:15:26+0200] Mart Raudsepp: |
| 2 |
> Ühel kenal päeval, K, 17.03.2021 kell 01:57, kirjutas Sam James: |
| 3 |
> > > +# @FUNCTION: gstreamer_multilib_src_install_all |
| 4 |
> > > +# @DESCRIPTION: |
| 5 |
> > > +# Installs documentation for requested gstreamer plugin, and |
| 6 |
> > > removes |
| 7 |
> > .la |
| 8 |
> > > +# files. |
| 9 |
> > > +gstreamer_multilib_src_install_all() { |
| 10 |
> > > + local plugin_dir |
| 11 |
> > > + |
| 12 |
> > > + for plugin_dir in ${GST_PLUGINS_BUILD_DIR} ; do |
| 13 |
> > > + local dir=$(gstreamer_get_plugin_dir |
| 14 |
> > > ${plugin_dir}) |
| 15 |
> > > + [[ -e ${dir}/README ]] && dodoc "${dir}"/README |
| 16 |
> > > + done |
| 17 |
> > > + |
| 18 |
> > > + prune_libtool_files --modules |
| 19 |
> > |
| 20 |
> > Deprecated in newer EAPIs, let’s do it manually. |
| 21 |
> |
| 22 |
> I don't think that ought to be necessary at all, as a meson build |
| 23 |
> wouldn't be generating libtool files. |
| 24 |
> |
| 25 |
> |
| 26 |
> My main initial question on this version is: |
| 27 |
> How does it behave with helper libraries from the same tarball? |
| 28 |
|
| 29 |
It has been in my overlay for a while (haven't included all the splitted plugins though). |
| 30 |
|
| 31 |
ie. https://hacktivis.me/git/overlay/file/media-plugins/gst-plugins-hls/gst-plugins-hls-1.18.4.ebuild.html |
| 32 |
|
| 33 |
> Basically what gstreamer_system_link function solved in the autotools |
| 34 |
> eclass. |
| 35 |
> E.g., if you build gst-plugins-libvisual, is it building gstreamer- |
| 36 |
> audio, gstreamer-video and gstreamer-pbutils as well again |
| 37 |
> (automatically due to generated ninja dependencies), or picks them up |
| 38 |
> from gst-plugins-base? |
| 39 |
|
| 40 |
I think this particular one isn't solved yet. Mainly because it doesn't |
| 41 |
seems to have caused me issues yet. |
| 42 |
|
| 43 |
> Some other quick notes: |
| 44 |
> |
| 45 |
> * I would prefer this being EAPI-7 only |
| 46 |
|
| 47 |
Yeah, as discussed in #gentoo-dev I'm doing this, pushed a WIP version in my |
| 48 |
overlay if you want to take an early look. |
| 49 |
|
| 50 |
> * Don't make nls optional |
| 51 |
|
| 52 |
What's the reason for this? It's the case with gstreamer::gentoo. |
| 53 |
|
| 54 |
> * It would be neat if we had a QA warning when a split plugin uses orc, |
| 55 |
> but doesn't have in IUSE for it (or vice-versa); maybe that's doable by |
| 56 |
> checking if the plugin meson.build uses orc_dep? |
| 57 |
|
| 58 |
Yeah, orc should be automatically added. |
Archives