1 |
Thanks for working on this, some very initial comments below |
2 |
|
3 |
Ühel kenal päeval, K, 17.03.2021 kell 01:57, kirjutas Sam James: |
4 |
> > +# @FUNCTION: gstreamer_multilib_src_install_all |
5 |
> > +# @DESCRIPTION: |
6 |
> > +# Installs documentation for requested gstreamer plugin, and |
7 |
> > removes |
8 |
> .la |
9 |
> > +# files. |
10 |
> > +gstreamer_multilib_src_install_all() { |
11 |
> > + local plugin_dir |
12 |
> > + |
13 |
> > + for plugin_dir in ${GST_PLUGINS_BUILD_DIR} ; do |
14 |
> > + local dir=$(gstreamer_get_plugin_dir |
15 |
> > ${plugin_dir}) |
16 |
> > + [[ -e ${dir}/README ]] && dodoc "${dir}"/README |
17 |
> > + done |
18 |
> > + |
19 |
> > + prune_libtool_files --modules |
20 |
> |
21 |
> Deprecated in newer EAPIs, let’s do it manually. |
22 |
|
23 |
I don't think that ought to be necessary at all, as a meson build |
24 |
wouldn't be generating libtool files. |
25 |
|
26 |
|
27 |
My main initial question on this version is: |
28 |
How does it behave with helper libraries from the same tarball? |
29 |
|
30 |
Basically what gstreamer_system_link function solved in the autotools |
31 |
eclass. |
32 |
E.g., if you build gst-plugins-libvisual, is it building gstreamer- |
33 |
audio, gstreamer-video and gstreamer-pbutils as well again |
34 |
(automatically due to generated ninja dependencies), or picks them up |
35 |
from gst-plugins-base? |
36 |
|
37 |
Some other quick notes: |
38 |
|
39 |
* I would prefer this being EAPI-7 only |
40 |
* Don't make nls optional |
41 |
* It would be neat if we had a QA warning when a split plugin uses orc, |
42 |
but doesn't have in IUSE for it (or vice-versa); maybe that's doable by |
43 |
checking if the plugin meson.build uses orc_dep? |
44 |
|
45 |
|
46 |
Mart |