1 |
On Sun, 2020-11-29 at 12:02 +0100, Ulrich Mueller wrote: |
2 |
> > > > > > On Sun, 29 Nov 2020, Michał Górny wrote: |
3 |
> |
4 |
> > + case ${install_method} in |
5 |
> > + home) |
6 |
> > + local add_args=( |
7 |
> > + install |
8 |
> > + --home="${TEST_DIR}" |
9 |
> > + --install-lib="${libdir}" |
10 |
> > + --install-scripts="${bindir}" |
11 |
> > + ) |
12 |
> > + mkdir -p "${libdir}" || die |
13 |
> > + ;; |
14 |
> > + root) |
15 |
> > + local add_args=( |
16 |
> > + install |
17 |
> > + --root="${TEST_DIR}" |
18 |
> > + --install-lib=lib |
19 |
> > + --install-scripts=scripts |
20 |
> > + ) |
21 |
> > + ;; |
22 |
> > + esac |
23 |
> |
24 |
> Having the same "local add_args" declaration twice looks strange and may |
25 |
> be error prone. Can you move it outside of the case statement? |
26 |
> |
27 |
> Also, why are the array elements at different indent levels? |
28 |
> |
29 |
|
30 |
Because they are options passed to 'install' command. |
31 |
|
32 |
-- |
33 |
Best regards, |
34 |
Michał Górny |