| 1 |
>>>>> On Sun, 29 Nov 2020, Michał Górny wrote: |
| 2 |
|
| 3 |
> + case ${install_method} in |
| 4 |
> + home) |
| 5 |
> + local add_args=( |
| 6 |
> + install |
| 7 |
> + --home="${TEST_DIR}" |
| 8 |
> + --install-lib="${libdir}" |
| 9 |
> + --install-scripts="${bindir}" |
| 10 |
> + ) |
| 11 |
> + mkdir -p "${libdir}" || die |
| 12 |
> + ;; |
| 13 |
> + root) |
| 14 |
> + local add_args=( |
| 15 |
> + install |
| 16 |
> + --root="${TEST_DIR}" |
| 17 |
> + --install-lib=lib |
| 18 |
> + --install-scripts=scripts |
| 19 |
> + ) |
| 20 |
> + ;; |
| 21 |
> + esac |
| 22 |
|
| 23 |
Having the same "local add_args" declaration twice looks strange and may |
| 24 |
be error prone. Can you move it outside of the case statement? |
| 25 |
|
| 26 |
Also, why are the array elements at different indent levels? |
| 27 |
|
| 28 |
Ulrich |
Archives