Gentoo Archives: gentoo-dev

From: Alexis Ballier <aballier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC: using array variables in qt4-r2.eclass
Date: Fri, 13 Jul 2012 13:51:57
Message-Id: 20120713095057.186f3dc3@gentoo.org
In Reply to: Re: [gentoo-dev] RFC: using array variables in qt4-r2.eclass by Davide Pesavento
1 On Fri, 13 Jul 2012 15:26:58 +0200
2 Davide Pesavento <pesa@g.o> wrote:
3
4 > > [...]
5 > >> + # backward compatibility for non-array variables
6 > >> + if [[ -n ${DOCS} ]] && [[ "$(declare -p DOCS 2>/dev/null
7 > >> 2>&1)" != "declare -a"* ]]; then
8 > >> + dodoc ${DOCS} || die "dodoc failed"
9 > >> + fi
10 > >> + if [[ -n ${HTML_DOCS} ]] && [[ "$(declare -p HTML_DOCS
11 > >> 2>/dev/null 2>&1)" != "declare -a"* ]]; then
12 > >> + dohtml -r ${HTML_DOCS} || die "dohtml failed"
13 > >> + fi
14 > >> }
15 > >
16 > > maybe issue an eqawarn in that case telling people to convert to
17 > > arrays; some time later make this an ewarn telling non-array support
18 > > will be removed and again later make this a die :)
19 > > (if you take that route i would expect you to start converting
20 > > packages to use arrays)
21 > >
22 >
23 > We have no intention of deprecating non-array variables in qt4-r2
24 > eclass.
25
26 why ? having two codepaths for the same thing, one being inferior,
27 sounds like a good reason to deprecate the inferior one :)
28
29 A.

Replies

Subject Author
Re: [gentoo-dev] RFC: using array variables in qt4-r2.eclass Davide Pesavento <pesa@g.o>