1 |
On Fri, Jul 13, 2012 at 3:50 PM, Alexis Ballier <aballier@g.o> wrote: |
2 |
> On Fri, 13 Jul 2012 15:26:58 +0200 |
3 |
> Davide Pesavento <pesa@g.o> wrote: |
4 |
> |
5 |
>> > [...] |
6 |
>> >> + # backward compatibility for non-array variables |
7 |
>> >> + if [[ -n ${DOCS} ]] && [[ "$(declare -p DOCS 2>/dev/null |
8 |
>> >> 2>&1)" != "declare -a"* ]]; then |
9 |
>> >> + dodoc ${DOCS} || die "dodoc failed" |
10 |
>> >> + fi |
11 |
>> >> + if [[ -n ${HTML_DOCS} ]] && [[ "$(declare -p HTML_DOCS |
12 |
>> >> 2>/dev/null 2>&1)" != "declare -a"* ]]; then |
13 |
>> >> + dohtml -r ${HTML_DOCS} || die "dohtml failed" |
14 |
>> >> + fi |
15 |
>> >> } |
16 |
>> > |
17 |
>> > maybe issue an eqawarn in that case telling people to convert to |
18 |
>> > arrays; some time later make this an ewarn telling non-array support |
19 |
>> > will be removed and again later make this a die :) |
20 |
>> > (if you take that route i would expect you to start converting |
21 |
>> > packages to use arrays) |
22 |
>> > |
23 |
>> |
24 |
>> We have no intention of deprecating non-array variables in qt4-r2 |
25 |
>> eclass. |
26 |
> |
27 |
> why ? having two codepaths for the same thing, one being inferior, |
28 |
> sounds like a good reason to deprecate the inferior one :) |
29 |
> |
30 |
> A. |
31 |
> |
32 |
|
33 |
Maintaining these two codepaths has practically zero cost, while |
34 |
forcing every ebuild using qt4-r2 to switch to arrays would waste |
35 |
developers' time which is better spent elsewhere. |
36 |
|
37 |
Furthermore, the non-array variant is not necessarily inferior, |
38 |
because it allows you to use bash globbing, brace expansion, etc... |
39 |
|
40 |
Thanks, |
41 |
Pesa |