1 |
On Tue, 29 Nov 2016 15:57:16 -0800 |
2 |
Brian Dolbec <dolsen@g.o> wrote: |
3 |
|
4 |
> While working on the last 2 version bumps to the twisted package, I |
5 |
> kept getting an error in which the *egg-info/SOURCES.txt file absolute |
6 |
> paths for all the files found in that very same directory. They are |
7 |
> required to be relative paths only. This problem currently only affects |
8 |
> some pkgs depending on the setuptools pkg for install. The source of |
9 |
> the change is that setuptools patches the cpython findall() with one |
10 |
> that returns relative paths for anything in/below the passed in base |
11 |
> directory. Everything else it returns the absolute path. |
12 |
> |
13 |
> Why we should apply this: |
14 |
> |
15 |
> Python upstream has merged the setuptools findall() code and will be |
16 |
> included in the next releases of python, 2.7.13, 3.4.6, 3.5.4 (I |
17 |
> think). So, there is potential for many more python pkgs to be |
18 |
> affected by this that are not requiring setuptools for install. |
19 |
> Without the ebb-base setting, the egg-info/* files are not included |
20 |
> in SOURCES.txt. The install proceeds without error. |
21 |
> |
22 |
> NOTE: This first affects the python_compile_all phase, long before |
23 |
> it even tries to run the tests (if enabled). |
24 |
> |
25 |
> |
26 |
> Some history: |
27 |
> |
28 |
> The egg-base settings were originally added for parallel |
29 |
> testing/install purposes. They are not used due to problems in |
30 |
> parallelizing testing, etc.. (something along those lines, I |
31 |
> don't want to search thru the logs, and mails to see what Michal's |
32 |
> original words were about it.) |
33 |
> |
34 |
> I am working on twisted-16.5.0 and 16.6.0 releases (tests are still |
35 |
> failing), but 16.6.0 has many improvements to the testing code, so has a |
36 |
> lot fewer errors to fix. Once these are fixed and the eclass changes |
37 |
> are merged, I will be able to add it to the tree. |
38 |
> |
39 |
> See attached patch. NOTE: actual commit message will be |
40 |
> different/updated correctly. This was just an interim patch for |
41 |
> testing and initial review. |
42 |
|
43 |
As I said before, just make sure this doesn't cause the wrong egg-info |
44 |
file to be installed accidentally. Possible corner case: when package |
45 |
does different egg for different Python versions. |
46 |
|
47 |
-- |
48 |
Best regards, |
49 |
Michał Górny |
50 |
<http://dev.gentoo.org/~mgorny/> |