Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Ulrich Mueller <ulm@g.o>
Cc: Gentoo Dev <gentoo-dev@l.g.o>, dist-kernel@g.o, base-system@g.o
Subject: Re: [gentoo-dev] [PATCH 1/8] dist-kernel-utils.eclass: support EAPI 8
Date: Thu, 08 Sep 2022 18:08:25
Message-Id: CAJ0EP41pvmYz9FKHfhUJmuCdqZtKSDn7CRtxX-T5Jh6ntO1Pdg@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH 1/8] dist-kernel-utils.eclass: support EAPI 8 by Ulrich Mueller
1 On Thu, Sep 8, 2022 at 1:38 PM Ulrich Mueller <ulm@g.o> wrote:
2 >
3 > >>>>> On Thu, 08 Sep 2022, Mike Gilbert wrote:
4 >
5 > > @@ -18,7 +18,7 @@ case "${EAPI:-0}" in
6 > > 0|1|2|3|4|5|6)
7 > > die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
8 > > ;;
9 > > - 7)
10 > > + 7|8)
11 > > ;;
12 > > *)
13 > > die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
14 >
15 > While at it, maybe convert the conditional to the standard form in all
16 > these eclasses? Like this:
17 >
18 > case ${EAPI} in
19 > 7|8) ;;
20 > *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
21 > esac
22 >
23 > I'd also drop EAPI 5 where it is applicable.
24
25 Done. Check the PR for updates.