Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@g.o
Subject: Re: [gentoo-dev] Some 'proper coding' notes for ebuilds
Date: Mon, 11 Aug 2003 14:58:45
Message-Id: 200308111058.46994.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] Some 'proper coding' notes for ebuilds by Patrick Kursawe
1 On Monday 11 August 2003 09:45, Patrick Kursawe wrote:
2 > Too sad I can't remember the name, but a while ago someone discouraged
3 > people from using epatch for simple patches because it's quite some
4 > overkill...
5 > If I have to apply just one or two patches, I don't see why I should not
6 > run patch from the ebuild.
7
8 too many people just run 'patch < patchfile' without checking for whether it
9 worked correctly ... plus, there are many ways to patch from gz/bzip2 (cat
10 it, uncompress it, pipe it, blah blah blah) ...
11 running 'epatch <patch file>' standardizes patch handling in all ebuilds, plus
12 developers dont have to worry about whether they did it correctly ... i know
13 it took me a while to figure out how to apply a freakin patch over a src base
14 :)
15
16 as for 'being overkill' ... yes, it has the ability to apply a ton of patches
17 very easily, but if you just give it a patch file, it'll skip all that other
18 code ... plus, if a patch fails, it shows nice output with a log file and
19 everything ...
20
21 hands down, azarah pwned the patch cmd
22 -mike
23
24 --
25 gentoo-dev@g.o mailing list