| 1 |
On 05/02/2013 03:40 PM, Pacho Ramos wrote: |
| 2 |
> El jue, 02-05-2013 a las 14:34 +0200, hasufell escribió: |
| 3 |
>> On 05/02/2013 12:41 PM, Pacho Ramos wrote: |
| 4 |
>>> gnome-games was splitted in separate packages per game and, then, we |
| 5 |
>>> need an eclass to also set proper settings inherited from gnome2 and |
| 6 |
>>> games eclasses. This should also solve: |
| 7 |
>>> https://bugs.gentoo.org/show_bug.cgi?id=432848 |
| 8 |
>>> |
| 9 |
>>> eclass and ebuild (games-puzzle/five-or-more) to try attached |
| 10 |
>>> |
| 11 |
>> |
| 12 |
>> This does not honour GAMES_DATADIR afais. |
| 13 |
> |
| 14 |
> They cannot honor it since installing all stuff under /usr/share/games |
| 15 |
> will lead to them even failing to start (I tried it before). |
| 16 |
> |
| 17 |
|
| 18 |
Why? |
| 19 |
|
| 20 |
It's a common problem that people hardcode data dir destination in their |
| 21 |
source files, assuming that people only want to install into /usr/share. |
| 22 |
That is simply a bug and needs to be fixed in the package (it also means |
| 23 |
it will probably fail for /usr/local and many other usecases, so this is |
| 24 |
not even a gentoo specific bug). |
| 25 |
|
| 26 |
You cannot fix that on eclass level and it is not a reason to drop |
| 27 |
supporting GAMES_DATADIR variable. That is inconsistent and does not |
| 28 |
make sense. You would even get mixed permissions unless you fix that up too. |
| 29 |
|
| 30 |
>> |
| 31 |
>> "prepgamesdirs" is missing completely too. |
| 32 |
>> |
| 33 |
>> So those games will not be compliant with the games.eclass standard. |
| 34 |
>> |
| 35 |
> |
| 36 |
> In games.eclass I see you have prepgamesdirs but don't call it on any |
| 37 |
> exported phase from games.eclass :-/, how are other games calling it? |
| 38 |
> |
| 39 |
> |
| 40 |
|
| 41 |
You call it explicitly. |
Archives