Re: [gentoo-dev] gnome-games.eclass: Eclass for installing all gnome-games

[Pacho Ramos]

El jue, 02-05-2013 a las 15:54 +0200, hasufell escribió:
> On 05/02/2013 03:40 PM, Pacho Ramos wrote:
> > El jue, 02-05-2013 a las 14:34 +0200, hasufell escribió:
> >> On 05/02/2013 12:41 PM, Pacho Ramos wrote:
> >>> gnome-games was splitted in separate packages per game and, then, we
> >>> need an eclass to also set proper settings inherited from gnome2 and
> >>> games eclasses. This should also solve:
> >>> https://bugs.gentoo.org/show_bug.cgi?id=432848
> >>>
> >>> eclass and ebuild (games-puzzle/five-or-more) to try attached
> >>>
> >>
> >> This does not honour GAMES_DATADIR afais.
> >
> > They cannot honor it since installing all stuff under /usr/share/games
> > will lead to them even failing to start (I tried it before).
> >
>
> Why?
>
> It's a common problem that people hardcode data dir destination in their
> source files, assuming that people only want to install into /usr/share.
> That is simply a bug and needs to be fixed in the package (it also means
> it will probably fail for /usr/local and many other usecases, so this is
> not even a gentoo specific bug).
>
> You cannot fix that on eclass level and it is not a reason to drop
> supporting GAMES_DATADIR variable. That is inconsistent and does not
> make sense. You would even get mixed permissions unless you fix that up too.
>

I don't understand why games team makes all this prefix work, isn't
changing permissions of installed files enough?

I doubt if upstream will be ok with installing
schemas/translations/gtk-doc stuff under this prefix :/

> >>
> >> "prepgamesdirs" is missing completely too.
> >>
> >> So those games will not be compliant with the games.eclass standard.
> >>
> >
> > In games.eclass I see you have prepgamesdirs but don't call it on any
> > exported phase from games.eclass :-/, how are other games calling it?
> >
> >
>
> You call it explicitly.
>

In src_install, no?