| 1 |
On 05/02/2013 05:12 PM, Pacho Ramos wrote: |
| 2 |
> El jue, 02-05-2013 a las 15:54 +0200, hasufell escribió: |
| 3 |
>> On 05/02/2013 03:40 PM, Pacho Ramos wrote: |
| 4 |
>>> El jue, 02-05-2013 a las 14:34 +0200, hasufell escribió: |
| 5 |
>>>> On 05/02/2013 12:41 PM, Pacho Ramos wrote: |
| 6 |
>>>>> gnome-games was splitted in separate packages per game and, then, we |
| 7 |
>>>>> need an eclass to also set proper settings inherited from gnome2 and |
| 8 |
>>>>> games eclasses. This should also solve: |
| 9 |
>>>>> https://bugs.gentoo.org/show_bug.cgi?id=432848 |
| 10 |
>>>>> |
| 11 |
>>>>> eclass and ebuild (games-puzzle/five-or-more) to try attached |
| 12 |
>>>>> |
| 13 |
>>>> |
| 14 |
>>>> This does not honour GAMES_DATADIR afais. |
| 15 |
>>> |
| 16 |
>>> They cannot honor it since installing all stuff under /usr/share/games |
| 17 |
>>> will lead to them even failing to start (I tried it before). |
| 18 |
>>> |
| 19 |
>> |
| 20 |
>> Why? |
| 21 |
>> |
| 22 |
>> It's a common problem that people hardcode data dir destination in their |
| 23 |
>> source files, assuming that people only want to install into /usr/share. |
| 24 |
>> That is simply a bug and needs to be fixed in the package (it also means |
| 25 |
>> it will probably fail for /usr/local and many other usecases, so this is |
| 26 |
>> not even a gentoo specific bug). |
| 27 |
>> |
| 28 |
>> You cannot fix that on eclass level and it is not a reason to drop |
| 29 |
>> supporting GAMES_DATADIR variable. That is inconsistent and does not |
| 30 |
>> make sense. You would even get mixed permissions unless you fix that up too. |
| 31 |
>> |
| 32 |
> |
| 33 |
> I don't understand why games team makes all this prefix work, isn't |
| 34 |
> changing permissions of installed files enough? |
| 35 |
> |
| 36 |
> I doubt if upstream will be ok with installing |
| 37 |
> schemas/translations/gtk-doc stuff under this prefix :/ |
| 38 |
> |
| 39 |
|
| 40 |
schemas/translations/gtk-doc don't need to be installed under that |
| 41 |
prefix. Sometimes you have to seperate install locations, otherwise you |
| 42 |
would end up getting pixmaps in /usr/share/games/pixmaps and such. |
| 43 |
|
| 44 |
That sometimes needs some micro-management. Datafiles should _always_ |
| 45 |
have a seperate switch to choose the destination. |
| 46 |
|
| 47 |
>>>> |
| 48 |
>>>> "prepgamesdirs" is missing completely too. |
| 49 |
>>>> |
| 50 |
>>>> So those games will not be compliant with the games.eclass standard. |
| 51 |
>>>> |
| 52 |
>>> |
| 53 |
>>> In games.eclass I see you have prepgamesdirs but don't call it on any |
| 54 |
>>> exported phase from games.eclass :-/, how are other games calling it? |
| 55 |
>>> |
| 56 |
>>> |
| 57 |
>> |
| 58 |
>> You call it explicitly. |
| 59 |
>> |
| 60 |
> |
| 61 |
> In src_install, no? |
| 62 |
> |
| 63 |
> |
| 64 |
|
| 65 |
Yes |
Archives