| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
This check was added to epatch all of a sudden breaking all working |
| 5 |
patches in the tree, although defending those patches having absolute |
| 6 |
paths, we as Java team had several bugs filed due to that. Maybe the |
| 7 |
tree should be scanned for those and fixed. |
| 8 |
|
| 9 |
Diego 'Flameeyes' Pettenò yazmış: |
| 10 |
> I ask it here as a favour, please avoid using absolute paths in the |
| 11 |
> filenames of patched files. This mean avoid having stuff like |
| 12 |
> |
| 13 |
> --- foobar/foo.c |
| 14 |
> +++ /tmp/foobar/foobar.c |
| 15 |
> |
| 16 |
> This tends to break from time to time, and I had to fix at least three |
| 17 |
> packages since I started my treewide build for these problems. I already |
| 18 |
> asked Zac about adding such a check on repoman, but in the mean time I'd |
| 19 |
> like to ask here for people to verify their packages. |
| 20 |
> |
| 21 |
> I actually am culprit of doing this some time ago but I learnt my lesson |
| 22 |
> the hard way :P My suggestion for everybody else is to use quilt when |
| 23 |
> you need to write patches. |
| 24 |
> |
| 25 |
> And if you have patches with the filenames like I shown above, you can |
| 26 |
> change it the git way so that it becomes: |
| 27 |
> |
| 28 |
> --- a/foobar/foo.c |
| 29 |
> +++ b/foobar/foo.c |
| 30 |
> |
| 31 |
> and the problem is usually solved. |
| 32 |
> |
| 33 |
> Thanks, |
| 34 |
|
| 35 |
- -- |
| 36 |
Sincerely, |
| 37 |
Serkan KABA |
| 38 |
Gentoo/Java |
| 39 |
-----BEGIN PGP SIGNATURE----- |
| 40 |
Version: GnuPG v2.0.9 (GNU/Linux) |
| 41 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org |
| 42 |
|
| 43 |
iEYEARECAAYFAkkhxhgACgkQRh6X64ivZaK4wwCeIUCZ6BIqWvo7tiFXpXa+Njpe |
| 44 |
AL4An2E5N+yGaIfv1kPaV4Gc9W8DG3M3 |
| 45 |
=2nhY |
| 46 |
-----END PGP SIGNATURE----- |
Archives