| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 17/01/13 11:00 AM, Pacho Ramos wrote: |
| 5 |
> |
| 6 |
> Another try ;) |
| 7 |
> |
| 8 |
|
| 9 |
|
| 10 |
There doesn't seem to be any logic here to check if the README.gentoo |
| 11 |
that was previously installed has differed from the one that will be |
| 12 |
installed (if they differ then the changes should be shown, no?) |
| 13 |
|
| 14 |
I think logic similar to the following could be added to ensure this |
| 15 |
occurs, though: |
| 16 |
|
| 17 |
readme.gentoo_check_update() { |
| 18 |
if [[ "${REPLACING_VERSIONS}" ]] ; then |
| 19 |
if diff -q "${T}"/README.gentoo \ |
| 20 |
"${EROOT}/usr/share/doc/${PF}"/README.gentoo &>/dev/null; then |
| 21 |
touch "${T}"/README.gentoo.show |
| 22 |
fi |
| 23 |
else |
| 24 |
touch "${T}"/README.gentoo.show |
| 25 |
fi |
| 26 |
} |
| 27 |
|
| 28 |
readme.gentoo_pkg_preinst() { |
| 29 |
debug-print-function ${FUNCNAME} "${@}" |
| 30 |
readme.gentoo_check_update |
| 31 |
} |
| 32 |
|
| 33 |
Then, export the pkg_preinst phase too, and and in |
| 34 |
readme.gentoo_print_elog , swap the conditional |
| 35 |
"! [[ ${REPLACING_VERSIONS} ]]" with "[[ -e ${T}/README.gentoo.show ]]" |
| 36 |
|
| 37 |
-----BEGIN PGP SIGNATURE----- |
| 38 |
Version: GnuPG v2.0.19 (GNU/Linux) |
| 39 |
|
| 40 |
iF0EAREIAAYFAlD4LKoACgkQ2ugaI38ACPCRvwD/Ub4EBc4ypYgfSItCSXc+ma2C |
| 41 |
nrNUySPoHE0Him8vwZkA+LXvVUCNYpwD+DRh/Q5wl5Le8yiDql5F3BuUN0EQU9g= |
| 42 |
=JbM2 |
| 43 |
-----END PGP SIGNATURE----- |
Archives