| 1 |
El jue, 17-01-2013 a las 07:47 -0800, Zac Medico escribió: |
| 2 |
[...] |
| 3 |
> >> Here are a few problems I see with readme.gentoo_print_elog: |
| 4 |
> >> |
| 5 |
> >> 1) contains duplication of code |
| 6 |
> >> |
| 7 |
> >> 2) [[ -f "${FILESDIR}/README.gentoo-${SLOT%/*}" ]] condition seems |
| 8 |
> >> wrong, shouldn't it just use [[ -f "${T}"/README.gentoo ]] since the |
| 9 |
> >> file was copied to "${T}"/README.gentoo iby readme.gentoo_create_doc? |
| 10 |
> > |
| 11 |
> > Yeah, probably both can be merged as checking for PACKAGENAME:SLOT |
| 12 |
> > should be enough, the problem is how to check it :S |
| 13 |
> > |
| 14 |
> >> |
| 15 |
> >> 3) [[ "${REPLACING_VERSIONS}:${SLOT%/*}" ]] condition seems wrong |
| 16 |
> >> because SLOT is always non-empty and that means the condition is always |
| 17 |
> >> true. |
| 18 |
> >> |
| 19 |
> > |
| 20 |
> > Is there a way to check if category/package_name:$SLOT was installed |
| 21 |
> > before merging? |
| 22 |
> |
| 23 |
> REPLACING_VERSIONS always refers to packages with identical SLOT to the |
| 24 |
> current package So, if ${REPLACING_VERSIONS} is non-empty, then the |
| 25 |
> current package replaces another package with identical SLOT. |
| 26 |
|
| 27 |
Another try ;) |
Archives