| 1 |
On 01/17/2013 07:17 AM, Pacho Ramos wrote: |
| 2 |
> El lun, 14-01-2013 a las 01:29 -0800, Zac Medico escribió: |
| 3 |
>> On 01/13/2013 04:59 AM, Pacho Ramos wrote: |
| 4 |
>>> El dom, 13-01-2013 a las 04:54 -0800, Zac Medico escribió: |
| 5 |
>>>> On 01/13/2013 04:18 AM, Pacho Ramos wrote: |
| 6 |
>>>>> What about this approach? |
| 7 |
>>>> |
| 8 |
>>>> You should use ${SLOT%/*}, in order to exclude the sub-slot, because you |
| 9 |
>>>> don't care about the sub-slot and the slash would cause problems. |
| 10 |
>>> |
| 11 |
>>> Thanks, updated eclass attached |
| 12 |
>>> |
| 13 |
>> |
| 14 |
>> Here are a few problems I see with readme.gentoo_print_elog: |
| 15 |
>> |
| 16 |
>> 1) contains duplication of code |
| 17 |
>> |
| 18 |
>> 2) [[ -f "${FILESDIR}/README.gentoo-${SLOT%/*}" ]] condition seems |
| 19 |
>> wrong, shouldn't it just use [[ -f "${T}"/README.gentoo ]] since the |
| 20 |
>> file was copied to "${T}"/README.gentoo iby readme.gentoo_create_doc? |
| 21 |
> |
| 22 |
> Yeah, probably both can be merged as checking for PACKAGENAME:SLOT |
| 23 |
> should be enough, the problem is how to check it :S |
| 24 |
> |
| 25 |
>> |
| 26 |
>> 3) [[ "${REPLACING_VERSIONS}:${SLOT%/*}" ]] condition seems wrong |
| 27 |
>> because SLOT is always non-empty and that means the condition is always |
| 28 |
>> true. |
| 29 |
>> |
| 30 |
> |
| 31 |
> Is there a way to check if category/package_name:$SLOT was installed |
| 32 |
> before merging? |
| 33 |
|
| 34 |
REPLACING_VERSIONS always refers to packages with identical SLOT to the |
| 35 |
current package So, if ${REPLACING_VERSIONS} is non-empty, then the |
| 36 |
current package replaces another package with identical SLOT. |
| 37 |
-- |
| 38 |
Thanks, |
| 39 |
Zac |
Archives