1 |
El lun, 14-01-2013 a las 01:29 -0800, Zac Medico escribió: |
2 |
> On 01/13/2013 04:59 AM, Pacho Ramos wrote: |
3 |
> > El dom, 13-01-2013 a las 04:54 -0800, Zac Medico escribió: |
4 |
> >> On 01/13/2013 04:18 AM, Pacho Ramos wrote: |
5 |
> >>> What about this approach? |
6 |
> >> |
7 |
> >> You should use ${SLOT%/*}, in order to exclude the sub-slot, because you |
8 |
> >> don't care about the sub-slot and the slash would cause problems. |
9 |
> > |
10 |
> > Thanks, updated eclass attached |
11 |
> > |
12 |
> |
13 |
> Here are a few problems I see with readme.gentoo_print_elog: |
14 |
> |
15 |
> 1) contains duplication of code |
16 |
> |
17 |
> 2) [[ -f "${FILESDIR}/README.gentoo-${SLOT%/*}" ]] condition seems |
18 |
> wrong, shouldn't it just use [[ -f "${T}"/README.gentoo ]] since the |
19 |
> file was copied to "${T}"/README.gentoo iby readme.gentoo_create_doc? |
20 |
|
21 |
Yeah, probably both can be merged as checking for PACKAGENAME:SLOT |
22 |
should be enough, the problem is how to check it :S |
23 |
|
24 |
> |
25 |
> 3) [[ "${REPLACING_VERSIONS}:${SLOT%/*}" ]] condition seems wrong |
26 |
> because SLOT is always non-empty and that means the condition is always |
27 |
> true. |
28 |
> |
29 |
|
30 |
Is there a way to check if category/package_name:$SLOT was installed |
31 |
before merging? |