| 1 |
On 01/13/2013 04:59 AM, Pacho Ramos wrote: |
| 2 |
> El dom, 13-01-2013 a las 04:54 -0800, Zac Medico escribió: |
| 3 |
>> On 01/13/2013 04:18 AM, Pacho Ramos wrote: |
| 4 |
>>> What about this approach? |
| 5 |
>> |
| 6 |
>> You should use ${SLOT%/*}, in order to exclude the sub-slot, because you |
| 7 |
>> don't care about the sub-slot and the slash would cause problems. |
| 8 |
> |
| 9 |
> Thanks, updated eclass attached |
| 10 |
> |
| 11 |
|
| 12 |
Here are a few problems I see with readme.gentoo_print_elog: |
| 13 |
|
| 14 |
1) contains duplication of code |
| 15 |
|
| 16 |
2) [[ -f "${FILESDIR}/README.gentoo-${SLOT%/*}" ]] condition seems |
| 17 |
wrong, shouldn't it just use [[ -f "${T}"/README.gentoo ]] since the |
| 18 |
file was copied to "${T}"/README.gentoo iby readme.gentoo_create_doc? |
| 19 |
|
| 20 |
3) [[ "${REPLACING_VERSIONS}:${SLOT%/*}" ]] condition seems wrong |
| 21 |
because SLOT is always non-empty and that means the condition is always |
| 22 |
true. |
| 23 |
|
| 24 |
-- |
| 25 |
Thanks, |
| 26 |
Zac |
Archives