Archives
Archives
| From: | Doug Goldstein <cardoe@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog | ||
| Date: | Sat, 04 Aug 2012 19:24:08 | ||
| Message-Id: | CAFWqQMSWgg1-YmmLrVB3YFeM+zKWi8X9Q9Gv06swMRDNT+mQ4w@mail.gmail.com | ||
| In Reply to: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog by Samuli Suominen |
||
| 1 | On Sat, Aug 4, 2012 at 2:31 AM, Samuli Suominen <ssuominen@g.o> wrote: |
| 2 | > If you don't use double [[ then ${ROOT} will need "" quoting |
| 3 | > |
| 4 | |
| 5 | Don't do top post code reviews. Snip out the context and do code |
| 6 | reviews inline so that your feedback is meaningful. Top posting and |
| 7 | leaving the entire commit with CVS metadata and all is just wasteful |
| 8 | and silly. |
| 9 | |
| 10 | -- |
| 11 | Doug Goldstein |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: udev-187-r1.ebuild udev-9999.ebuild ChangeLog | William Hubbs <williamh@g.o> |