| 1 |
On Sat, Aug 04, 2012 at 02:22:52PM -0500, Doug Goldstein wrote: |
| 2 |
> On Sat, Aug 4, 2012 at 2:31 AM, Samuli Suominen <ssuominen@g.o> wrote: |
| 3 |
> > If you don't use double [[ then ${ROOT} will need "" quoting |
| 4 |
> > |
| 5 |
> |
| 6 |
> Don't do top post code reviews. Snip out the context and do code |
| 7 |
> reviews inline so that your feedback is meaningful. Top posting and |
| 8 |
> leaving the entire commit with CVS metadata and all is just wasteful |
| 9 |
> and silly. |
| 10 |
|
| 11 |
This has been fixed. |
| 12 |
|
| 13 |
WRT Doug's request, the important part is "snip out the context". Don't |
| 14 |
just insert comments and leave the entire commit in the message. |
| 15 |
|
| 16 |
Thanks, |
| 17 |
|
| 18 |
William |
Archives