| 1 |
On Saturday 17 June 2006 01:22, Alin Nastac wrote: |
| 2 |
> Thomas Cort wrote: |
| 3 |
> > What is the proper quoting style for using epatch? In the tree there |
| 4 |
> > are about 3 different styles... |
| 5 |
> > |
| 6 |
> > epatch ${FILESDIR}/some-fix.patch # used by 7326 ebuilds |
| 7 |
> > epatch "${FILESDIR}"/some-fix.patch # used by 3092 ebuilds |
| 8 |
> > epatch "${FILESDIR}/some-fix.patch" # used by 1434 ebuilds |
| 9 |
> |
| 10 |
> 2 and 3 are fine. |
| 11 |
|
| 12 |
correct ... personally i prefer the 2nd myself |
| 13 |
|
| 14 |
> > What is the proper quoting style for defining the S variable? In the |
| 15 |
> > tree there are about 3 different styles... |
| 16 |
> > |
| 17 |
> > S=${WORKDIR}/${MY_P} # used by 5270 ebuilds |
| 18 |
> > S="${WORKDIR}"/${MY_P} # used by 43 ebuilds |
| 19 |
> > S="${WORKDIR}/${MY_P}" # used by 2259 ebuilds |
| 20 |
> |
| 21 |
> ditto |
| 22 |
|
| 23 |
not really ... all three will work fine, but i prefer the first myself as the |
| 24 |
quoting is not needed here |
| 25 |
-mike |
Archives