Gentoo Archives: gentoo-dev

From: Duncan <1i5t5.duncan@×××.net>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: variable quoting, setting optional variables to "", and depending on virtual/libc
Date: Sat, 17 Jun 2006 09:07:21
Message-Id: e70gb6$ugt$2@sea.gmane.org
In Reply to: Re: [gentoo-dev] variable quoting, setting optional variables to "", and depending on virtual/libc by Mike Frysinger
1 Mike Frysinger <vapier@g.o> posted
2 200606170330.29685.vapier@g.o, excerpted below, on Sat, 17 Jun
3 2006 03:30:29 -0400:
4
5 >> > What is the proper quoting style for defining the S variable? In the
6 >> > tree there are about 3 different styles...
7 >> >
8 >> > S=${WORKDIR}/${MY_P} # used by 5270 ebuilds
9 >> > S="${WORKDIR}"/${MY_P} # used by 43 ebuilds
10 >> > S="${WORKDIR}/${MY_P}" # used by 2259 ebuilds
11 >>
12 >> ditto
13 >
14 > not really ... all three will work fine, but i prefer the first myself as the
15 > quoting is not needed here
16
17 What if someone has PORTAGE_TMPDIR="/tmp/portage temporary workspace" or
18 "/var/tmp/\$whatever" or some such (yes I know that's crazy, but...)? I'd
19 agree with the ditto, not with the all three will work fine.
20
21 --
22 Duncan - List replies preferred. No HTML msgs.
23 "Every nonfree program has a lord, a master --
24 and if you use the program, he is your master." Richard Stallman
25
26 --
27 gentoo-dev@g.o mailing list

Replies