Re: [gentoo-dev] KDE4 eclasses review

[Marc Schiffbauer]

* TomᨠChvátal schrieb am 04.04.11 um 19:00 Uhr:
> Hi guys,
> since we didn't do this for quite long time I would like kde4 eclasses
> reviewed as whole rather than on patch basis (altho i attach the patches
> for convenience too).
>
> It is 2 years since we reviewed them last time fully on -dev so lets see
> how much weird/useless logic we can find (more heads know more).
>
> Remember: nitpick on everything cause this thing is used in quite a lot
> ebuilds so we need it in top-notch shape :)
>
> This update brings support for git since upstream is slowly moving to
> git repos from SVN. Dropped support for eapi2. Usage of fdo/gnome
> classes to update mime stuff. Most of the koffice code removed as being
> obsoleted and various loads of whitespace stuff.
>
> Cheers
>
> Tom

> # Copyright 1999-2010 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2
> # $Header: $
>
> # @ECLASS: kde4-base.eclass
> # @MAINTAINER:
> # kde@g.o
> # @BLURB: This eclass provides functions for kde 4.X ebuilds
> # @DESCRIPTION:
> # The kde4-base.eclass provides support for building KDE4 based ebuilds
> # and KDE4 applications.
> #
> # NOTE: KDE 4 ebuilds currently support EAPI "3".  This will be reviewed
> # over time as new EAPI versions are approved.
>
> # @ECLASS-VARIABLE: VIRTUALX_REQUIRED
> # @DESCRIPTION:
> # For proper description see virtualx.eclass manpage.
> # Here we redefine default value to be manual, if your package needs virtualx
> # for tests you should proceed with setting VIRTUALX_REQUIRED=test.
> : ${VIRTUALX_REQUIRED:=manual}

[...]

>
> KDE_MINIMAL="${KDE_MINIMAL:-4.4}"

I'd suggest setting default for all variables the same way. I
personally like the : {X:="default"} approach best.

: ${KDE_MINIMAL:=4.4} 

-Marc
-- 
8AAC 5F46 83B4 DB70 8317  3723 296C 6CCA 35A6 4134