1 |
On Sun, Sep 23, 2018 at 3:33 PM M. J. Everitt <m.j.everitt@×××.org> wrote: |
2 |
> |
3 |
> On 23/09/18 16:20, Mike Gilbert wrote: |
4 |
> > Signed-off-by: Mike Gilbert <floppym@g.o> |
5 |
> > --- |
6 |
> > eclass/udev.eclass | 14 +++++++++----- |
7 |
> > 1 file changed, 9 insertions(+), 5 deletions(-) |
8 |
> > |
9 |
> > diff --git a/eclass/udev.eclass b/eclass/udev.eclass |
10 |
> > index 4f23c9ebbdf8..baf60584938f 100644 |
11 |
> > --- a/eclass/udev.eclass |
12 |
> > +++ b/eclass/udev.eclass |
13 |
> > @@ -1,10 +1,10 @@ |
14 |
> > -# Copyright 1999-2014 Gentoo Foundation |
15 |
> > +# Copyright 1999-2018 Gentoo Authors |
16 |
> > # Distributed under the terms of the GNU General Public License v2 |
17 |
> > |
18 |
> > # @ECLASS: udev.eclass |
19 |
> > # @MAINTAINER: |
20 |
> > # udev-bugs@g.o |
21 |
> > -# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6 |
22 |
> > +# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6 7 |
23 |
> > # @BLURB: Default eclass for determining udev directories. |
24 |
> > # @DESCRIPTION: |
25 |
> > # Default eclass for determining udev directories. |
26 |
> > @@ -34,12 +34,16 @@ _UDEV_ECLASS=1 |
27 |
> > inherit toolchain-funcs |
28 |
> > |
29 |
> > case ${EAPI:-0} in |
30 |
> > - 0|1|2|3|4|5|6) ;; |
31 |
> > + 0|1|2|3|4|5|6|7) ;; |
32 |
> > *) die "${ECLASS}.eclass API in EAPI ${EAPI} not yet established." |
33 |
> > esac |
34 |
> > |
35 |
> > -RDEPEND="" |
36 |
> > -DEPEND="virtual/pkgconfig" |
37 |
> > +if [[ ${EAPI:-0} == [0123456] ]]; then |
38 |
> > + RDEPEND="" |
39 |
> > + DEPEND="virtual/pkgconfig" |
40 |
> > +else |
41 |
> > + BDEPEND="virtual/pkgconfig" |
42 |
> > +fi |
43 |
> > |
44 |
> > # @FUNCTION: _udev_get_udevdir |
45 |
> > # @INTERNAL |
46 |
> Hate to nit-pick, but this *is* Gentoo .. the last IF, if EAPI <> 7 then |
47 |
> BDEPEND could also be dragged in, probably better to explicitly mention '7'. |
48 |
|
49 |
That's by design: future EAPIs will probably have BDEPEND, and I don't |
50 |
want to have to update this if statement for every new EAPI. |