1 |
On 07/10/2018 09:44 AM, Rich Freeman wrote: |
2 |
> On Tue, Jul 10, 2018 at 9:38 AM kuzetsa <kuzetsa@×××××.com> wrote: |
3 |
>> |
4 |
>> I think authorship is a good point / distinction, Mart. |
5 |
>> |
6 |
>> Authorship was never shown in dev-timeline for addresses |
7 |
>> which aren't @gentoo.org anyway. That's a separate issue, |
8 |
>> so this policy change shouldn't affect proxy-maint? |
9 |
>> |
10 |
> |
11 |
> Might I suggest bringing authorship issues into a separate thread? It |
12 |
> really seems like a completely separate issue. IMO devs who are |
13 |
> authors but not committers should probably also use their @g.o |
14 |
> addresses, though it is a little less critical there. We're talking |
15 |
> about the committer here, and the committer will always be a Gentoo |
16 |
> dev for these repos, and I don't see any reason that we shouldn't have |
17 |
> a matching email address between that and LDAP. The alternative would |
18 |
> be to have some other key, and that just seems overly complex. |
19 |
> |
20 |
|
21 |
Authorship was brought up by: [ Mart Raudsepp <leio@g.o> ] |
22 |
|
23 |
It's germane, and wanting clarity doesn't hurt: |
24 |
|
25 |
... as quoted here: |
26 |
|
27 |
On 07/09/2018 06:29 AM, Mart Raudsepp wrote: |
28 |
> As long as that doesn't imply authorship, which seems to be as planned |
29 |
> (for committer field only, as you said). Hopefully it's easy for people |
30 |
> to set it up so that it uses gentoo address for committer and something |
31 |
> else for author, albeit I don't see any config for it, but should be |
32 |
> able to at least go via a script that uses the appropriate env vars. |
33 |
~{prune}~ |
34 |
|
35 |
> Mart |
36 |
> |
37 |
|
38 |
^ As I think Mart may have been asking: |
39 |
(or maybe just a related concern) |
40 |
|
41 |
To avoid mistakes and confusion, it should be stated |
42 |
unambiguously if //only// the commit field should be |
43 |
modified (if not already a @gentoo.org address), and |
44 |
the author field (in particular, commits authored by |
45 |
persons not in LDAP / without @gentoo.org addresses) |
46 |
ought to be left as-is, or if the intent is to imply |
47 |
that both fields need to be @gentoo.org address. |
48 |
|
49 |
Stating clearly that the author field should be left |
50 |
as-is (if it's set to a non-@g.o address) is |
51 |
probably enough here. |
52 |
|
53 |
I think the confusion may have partly been the |
54 |
subject line for this thread, vaguely worded: |
55 |
|
56 |
["... use their @gentoo.org address ..."], |
57 |
|
58 |
which may accidentally imply that committers need to |
59 |
apply @gentoo.org in all fields, not just committer. |
60 |
|
61 |
the word "only" was in a few places, but if skimming |
62 |
the thread it may not have been obvious. ::shrug:: |
63 |
|
64 |
Also, I agree: |
65 |
|
66 |
dev-timeline tool not recognizing authorship ought to |
67 |
be an issue for a separate thread, as this one seems |
68 |
to be about the metadata in the commits themselves. |
69 |
|
70 |
--kuza |