Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: "Amadeusz Żołnowski" <aidecoe@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] rebar.eclass: Build Erlang/OTP projects using dev-util/rebar
Date: Sat, 21 May 2016 07:01:21
Message-Id: 20160521090058.5133ab74.mgorny@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] rebar.eclass: Build Erlang/OTP projects using dev-util/rebar by "Amadeusz Żołnowski"
1 On Sat, 21 May 2016 00:06:01 +0100
2 Amadeusz Żołnowski <aidecoe@g.o> wrote:
3
4 > >> +rebar_src_install() {
5 > >> + debug-print-function ${FUNCNAME} "${@}"
6 > >> +
7 > >> + local bin
8 > >> + local dest="$(get_erl_libs)/${P}"
9 > >> +
10 > >> + insinto "${dest}"
11 > >> + doins -r ebin
12 > >> + [[ -d include ]] && doins -r include
13 > >> + [[ -d bin ]] && for bin in bin/*; do dobin "$bin"; done
14 > >
15 > > Please don't do inlines like this.
16 >
17 > Is there a particular problem with this?
18
19 Readability and maintainability. At some point someone may want to
20 extend this, and it will no longer work as one-liner.
21
22 --
23 Best regards,
24 Michał Górny
25 <http://dev.gentoo.org/~mgorny/>

Replies