| 1 |
Michał Górny <mgorny@g.o> writes: |
| 2 |
>> >> + [[ -d include ]] && doins -r include |
| 3 |
>> >> + [[ -d bin ]] && for bin in bin/*; do dobin "$bin"; done |
| 4 |
>> > |
| 5 |
>> > Please don't do inlines like this. |
| 6 |
>> |
| 7 |
>> Is there a particular problem with this? |
| 8 |
> |
| 9 |
> Readability and maintainability. At some point someone may want to |
| 10 |
> extend this, and it will no longer work as one-liner. |
| 11 |
|
| 12 |
That's rather subjective. Given the context I find concise. When |
| 13 |
uninlined it takes 4 lines more, gets out of context and looks more |
| 14 |
noisy to me. If someone would like to extend the inline version it could |
| 15 |
be uninlined at that point. |
| 16 |
|
| 17 |
-- |
| 18 |
Amadeusz Żołnowski |
Archives