[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

[Michał Górny]

Mike,

On wto, 2017-05-16 at 19:10 +0000, Mike Frysinger wrote:
> commit:     d1b05bcf81e5058c20615179fb83a90c45daa487
> Author:     Mike Frysinger <vapier <AT> chromium <DOT> org>
> AuthorDate: Tue May  9 02:34:53 2017 +0000
> Commit:     Mike Frysinger <vapier <AT> gentoo <DOT> org>
> CommitDate: Tue May 16 19:10:31 2017 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1b05bcf
>
> python-utils-r1.eclass: add more info to stub python wrappers
>
> The short terse error messages here are not easy to track down.  Add
> a few more details so people can figure out what's going wrong faster.
>
>  eclass/python-utils-r1.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
> index c1349ff277b..0bf7e7ec1a3 100644
> --- a/eclass/python-utils-r1.eclass
> +++ b/eclass/python-utils-r1.eclass
> @@ -1041,7 +1041,7 @@ python_wrapper_setup() {
>  		for x in "${nonsupp[@]}"; do
>  			cat >"${workdir}"/bin/${x} <<-_EOF_ || die
>  				#!/bin/sh
> -				echo "${x} is not supported by ${EPYTHON}" >&2
> +				echo "${ECLASS}: ${FUNCNAME}: ${x} is not supported by ${EPYTHON} (PYTHON_COMPAT)" >&2
>  				exit 127
>  			_EOF_
>  			chmod +x "${workdir}"/bin/${x} || die

I would really appreciate if you cared to follow procedures for eclass
changes. Most notably, if you at least bothered to either ping us *or*
sent the patch to the mailing list beforehand.

This eclass is used by almost 6700 ebuilds. I am trying *hard* to commit
changes in large patchsets to reduce cache updates. Of course it is all
pointless if a random Mike Frysinger, developer on special rights, goes
ahead and commits whatever he wants to whatever eclasses he wants to
commit to, whatever time he pleases.

Normally, I would revert it but I don't feel like causing third huge
cache update today.

-- 
Best regards,
Michał Górny